[GitHub] [spark] liang3zy22 commented on a diff in pull request #40657: [SPARK-42844][SQL] Update the error class `_LEGACY_ERROR_TEMP_2008` to `INVALID_URL`

["liang3zy22 (via GitHub)" <gi...@apache.org>]

liang3zy22 commented on code in PR #40657:
URL: https://github.com/apache/spark/pull/40657#discussion_r1158135907


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -1832,16 +1833,22 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
   }
 
   test("SPARK-33468: ParseUrl in ANSI mode should fail if input string is not a valid url") {

Review Comment:
   You mean add test case in UrlFunctionsSuite to use sql("SELECT parse_url(...)") command with ANSI disabled? There is already one test case in UrlFunctionSuite with ANSI disabled, using df.selectExpr("parse_url()") method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org