[GitHub] [yunikorn-release] DerekTBrown commented on pull request #110: [YUNIKORN-1261] Add pre-upgrade hook

[GitBox <gi...@apache.org>]

DerekTBrown commented on PR #110:
URL: https://github.com/apache/yunikorn-release/pull/110#issuecomment-1279475756

   @wilfred-s I apologize- I put this up-for-review prematurely. 
   
   I think YuniKorn is in a highly similar place to Spark Operator in terms of Helm hooks:
   https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/1624
   
   What we really need is first-order support for resource ordering. Unfortunately, the hooks have weird semantics that make it hard for us to get the desired behavior.
   
   I am going to wait for the conversation in https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/1624
    to resolve, and then we can decide whether we want to adopt this same approach within YuniKorn. The Spark Operator only has 3 instances of the hook, whereas I see 12 in YuniKorn, so this might be more heavy-handed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org