You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/12/27 12:26:17 UTC
[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3537:
Metacache issues
vikramahuja1001 opened a new pull request #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when
using index server. 2. Filter query failure with Index server when loaded
with global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362406661
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +127,19 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
+ def createIndexServerTmp(sparkSession: SparkSession): Unit = {
+ val path = CarbonUtil.checkAndAppendFileSystemURIScheme(
+ "/tmp/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME)
+ if (!FileFactory.isFileExist(path)) {
+ // Create the new directory
+ LOGGER.info(s"Creating Index Server Tmp folder: ${path} ")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570170908
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1405/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569927454
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1379/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570464419
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1413/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index
Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362427255
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/cache/CarbonDropCacheCommand.scala
##########
@@ -49,18 +49,19 @@ case class CarbonDropCacheCommand(tableIdentifier: TableIdentifier, internalCall
OperationListenerBus.getInstance.fireEvent(dropCacheEvent, operationContext)
val cache = CacheProvider.getInstance().getCarbonCache
+ // Clearing cache from IndexServer
+ if (CarbonProperties.getInstance().isDistributedPruningEnabled(carbonTable.getDatabaseName,
+ carbonTable.getTableName)) {
+ LOGGER.info("Clearing cache from IndexServer")
+ DataMapUtil.executeClearDataMapJob(carbonTable, DataMapUtil.DISTRIBUTED_JOB_NAME)
+ }
if (cache != null) {
- // Get all Index files for the specified table.
- if (CarbonProperties.getInstance().isDistributedPruningEnabled(carbonTable.getDatabaseName,
- carbonTable.getTableName)) {
- DataMapUtil.executeClearDataMapJob(carbonTable, DataMapUtil.DISTRIBUTED_JOB_NAME)
- } else {
- // Extract dictionary keys for the table and create cache keys from those
- val dictKeys: List[String] = CacheUtil.getAllDictCacheKeys(carbonTable)
- // Remove elements from cache
- cache.removeAll(dictKeys.asJava)
- DataMapStoreManager.getInstance().clearDataMaps(carbonTable.getAbsoluteTableIdentifier)
- }
+ LOGGER.info("Clearing cache from driver side")
+ // Extract dictionary keys for the table and create cache keys from those
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573517893
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] MakKind commented on issue #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
MakKind commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570219597
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570479759
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570183903
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1409/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362202583
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +130,21 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
+ def createIndexServerTmp(sparkSession: SparkSession): Unit = {
+ val conf = sparkSession.sparkContext.hadoopConfiguration
+ val fs = FileSystem.get(conf)
+ if (fs.getUri.toString.startsWith("hdfs://")) {
Review comment:
Use CarbonUtil.checkAndAppendFileSystemURIScheme to add URI to the path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537: Metacache
issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569274070
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1320/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-574999652
@kunal642 , done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537: Metacache
issues
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569908950
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569936628
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1389/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570173448
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1417/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570475179
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362374380
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +127,19 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
+ def createIndexServerTmp(sparkSession: SparkSession): Unit = {
Review comment:
We already have a method to create temp folder in CarbonUtil. Please use the same method and add the code to change the permission to 777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570480246
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376348
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/cache/CarbonDropCacheCommand.scala
##########
@@ -49,18 +49,19 @@ case class CarbonDropCacheCommand(tableIdentifier: TableIdentifier, internalCall
OperationListenerBus.getInstance.fireEvent(dropCacheEvent, operationContext)
val cache = CacheProvider.getInstance().getCarbonCache
+ // Clearing cache from IndexServer
+ if (CarbonProperties.getInstance().isDistributedPruningEnabled(carbonTable.getDatabaseName,
+ carbonTable.getTableName)) {
+ LOGGER.info("Clearing cache from IndexServer")
+ DataMapUtil.executeClearDataMapJob(carbonTable, DataMapUtil.DISTRIBUTED_JOB_NAME)
+ }
if (cache != null) {
- // Get all Index files for the specified table.
- if (CarbonProperties.getInstance().isDistributedPruningEnabled(carbonTable.getDatabaseName,
- carbonTable.getTableName)) {
- DataMapUtil.executeClearDataMapJob(carbonTable, DataMapUtil.DISTRIBUTED_JOB_NAME)
- } else {
- // Extract dictionary keys for the table and create cache keys from those
- val dictKeys: List[String] = CacheUtil.getAllDictCacheKeys(carbonTable)
- // Remove elements from cache
- cache.removeAll(dictKeys.asJava)
- DataMapStoreManager.getInstance().clearDataMaps(carbonTable.getAbsoluteTableIdentifier)
- }
+ LOGGER.info("Clearing cache from driver side")
+ // Extract dictionary keys for the table and create cache keys from those
Review comment:
please corect the comment, its not clear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when
using index server. 2. Filter query failure with Index server when loaded
with global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362203886
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -45,6 +47,8 @@ import org.apache.carbondata.processing.loading.events.LoadEvents.{LoadMetadataE
import org.apache.carbondata.spark.rdd.SparkReadSupport
import org.apache.carbondata.spark.readsupport.SparkRowReadSupportImpl
+
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570153358
Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1394/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when
using index server. 2. Filter query failure with Index server when loaded
with global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362203892
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +130,21 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
+ def createIndexServerTmp(sparkSession: SparkSession): Unit = {
+ val conf = sparkSession.sparkContext.hadoopConfiguration
+ val fs = FileSystem.get(conf)
+ if (fs.getUri.toString.startsWith("hdfs://")) {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570480246
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570474258
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1435/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570488935
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1417/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 commented on issue #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
kunal642 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575528882
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570478426
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575150787
@kunal642 , done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-572920734
@kunal642 , @akashrn5 , please give LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570477850
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 commented on issue #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
kunal642 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-574988863
@vikramahuja1001 Please rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570153985
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1416/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537: Metacache
issues
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569896692
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362201899
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -45,6 +47,8 @@ import org.apache.carbondata.processing.loading.events.LoadEvents.{LoadMetadataE
import org.apache.carbondata.spark.rdd.SparkReadSupport
import org.apache.carbondata.spark.readsupport.SparkRowReadSupportImpl
+
Review comment:
revert this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537: Metacache
issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569900901
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1395/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570480627
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570480874
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569923726
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570159452
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1396/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index
Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362427225
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -71,6 +70,8 @@ class CarbonEnv {
properties.addProperty(CarbonCommonConstants.STORE_LOCATION, storePath)
}
LOGGER.info(s"Initializing CarbonEnv, store location: $storePath")
+ // Creating the index server tepm folder where splits for select query is written
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570222331
Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1402/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575024427
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-574999691
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376259
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +127,19 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
+ def createIndexServerTmp(sparkSession: SparkSession): Unit = {
+ val path = CarbonUtil.checkAndAppendFileSystemURIScheme(
+ "/tmp/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME)
+ if (!FileFactory.isFileExist(path)) {
+ // Create the new directory
+ LOGGER.info(s"Creating Index Server Tmp folder: ${path} ")
Review comment:
either give `tmp` or `temp` in log, remove Tmp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-572568660
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1569/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570587221
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1452/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when
using index server. 2. Filter query failure with Index server when loaded
with global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362406718
##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -3321,7 +3321,7 @@ public static String getIndexServerTempPath(String tablePath, String queryId) {
.getProperty(CarbonCommonConstants.CARBON_INDEX_SERVER_TEMP_PATH);
if (null == tempFolderPath) {
tempFolderPath =
- tablePath + "/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME + "/" + queryId;
+ "/tmp/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME + "/" + queryId;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570476331
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570476331
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362374604
##########
File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
##########
@@ -3321,7 +3321,7 @@ public static String getIndexServerTempPath(String tablePath, String queryId) {
.getProperty(CarbonCommonConstants.CARBON_INDEX_SERVER_TEMP_PATH);
if (null == tempFolderPath) {
tempFolderPath =
- tablePath + "/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME + "/" + queryId;
+ "/tmp/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME + "/" + queryId;
Review comment:
use CarbonCommonConstants.FILE_SEPARATOR instead on "/" in the method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570510926
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1437/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-572538636
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570154451
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537: Metacache
issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569898197
Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1374/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570475179
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when
using index server. 2. Filter query failure with Index server when loaded
with global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362406682
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +127,19 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570479759
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570481251
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575044921
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when
using index server. 2. Filter query failure with Index server when loaded
with global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362406737
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +127,19 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
+ def createIndexServerTmp(sparkSession: SparkSession): Unit = {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569912856
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1378/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376155
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -71,6 +72,7 @@ class CarbonEnv {
properties.addProperty(CarbonCommonConstants.STORE_LOCATION, storePath)
}
LOGGER.info(s"Initializing CarbonEnv, store location: $storePath")
+ createIndexServerTmp(sparkSession);
Review comment:
please add a comment, why is this required and what is this used for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570153160
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1404/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376318
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/cache/CarbonDropCacheCommand.scala
##########
@@ -49,18 +49,19 @@ case class CarbonDropCacheCommand(tableIdentifier: TableIdentifier, internalCall
OperationListenerBus.getInstance.fireEvent(dropCacheEvent, operationContext)
val cache = CacheProvider.getInstance().getCarbonCache
+ // Clearing cache from IndexServer
Review comment:
change commnet from `clearing` to `clear`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570565545
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570483415
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570480874
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570480627
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376184
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -125,6 +127,19 @@ class CarbonEnv {
LOGGER.info("Initialize CarbonEnv completed...")
}
+
Review comment:
please add method level comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
kunal642 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515669
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569924691
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1384/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570474903
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
akashrn5 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515731
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570222476
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1411/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362422396
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -71,6 +70,8 @@ class CarbonEnv {
properties.addProperty(CarbonCommonConstants.STORE_LOCATION, storePath)
}
LOGGER.info(s"Initializing CarbonEnv, store location: $storePath")
+ // Creating the index server tepm folder where splits for select query is written
Review comment:
temp spelling is wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570172704
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1400/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569918773
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1388/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570484236
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569920825
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1400/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570476732
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1421/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570477850
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573534758
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1620/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570185599
Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1401/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570185784
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using
index server. 2. Filter query failure with Index server when loaded with
global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569941202
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1401/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570460363
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570185558
Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1410/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575026446
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1656/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575529343
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570474903
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515731
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when
using index server. 2. Filter query failure with Index server when loaded
with global_sort_partition = 100000, giving Null pointer exception
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index server when loaded with global_sort_partition = 100000, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362406698
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
##########
@@ -71,6 +72,7 @@ class CarbonEnv {
properties.addProperty(CarbonCommonConstants.STORE_LOCATION, storePath)
}
LOGGER.info(s"Initializing CarbonEnv, store location: $storePath")
+ createIndexServerTmp(sparkSession);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575052122
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1659/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575001422
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1652/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537: Metacache
issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569262987
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1299/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request
#3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index
Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362427272
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/cache/CarbonDropCacheCommand.scala
##########
@@ -49,18 +49,19 @@ case class CarbonDropCacheCommand(tableIdentifier: TableIdentifier, internalCall
OperationListenerBus.getInstance.fireEvent(dropCacheEvent, operationContext)
val cache = CacheProvider.getInstance().getCarbonCache
+ // Clearing cache from IndexServer
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570185539
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1423/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570478426
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ydvpankaj97 removed a comment on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
ydvpankaj97 removed a comment on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570483415
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570502397
Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1425/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575121516
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] kunal642 commented on issue #3537: [CARBONDATA-3646]
[CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
kunal642 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-573515669
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] vikramahuja1001 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-570184645
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537: Metacache
issues
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: Metacache issues
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-569286118
Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1308/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3537:
[CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3537: [CARBONDATA-3646] [CARBONDATA-3647]: Fix query failure with Index Server
URL: https://github.com/apache/carbondata/pull/3537#issuecomment-575150307
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1668/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services