You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/10/15 20:03:48 UTC
Review Request 39349: Add a Stout wrapper for pipe(2).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39349/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2079
https://issues.apache.org/jira/browse/MESOS-2079
Repository: mesos
Description
-------
Add a Stout wrapper for pipe(2).
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
3rdparty/libprocess/3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 4bb79fdc161483cfc2b7a7a15e5c3ce62ceb493d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5
Diff: https://reviews.apache.org/r/39349/diff/
Testing
-------
OS X and CentOS 6
make && make check
Thanks,
James Peach
Re: Review Request 39349: Add a Stout wrapper for pipe(2).
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39349/#review102889
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pipe.hpp (line 26)
<https://reviews.apache.org/r/39349/#comment160697>
Is it possible to change to "int fildes[2]"
- haosdent huang
On Oct. 15, 2015, 6:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39349/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 6:03 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a Stout wrapper for pipe(2).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 4bb79fdc161483cfc2b7a7a15e5c3ce62ceb493d
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5
>
> Diff: https://reviews.apache.org/r/39349/diff/
>
>
> Testing
> -------
>
> OS X and CentOS 6
> make && make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39349: Add a Stout wrapper for pipe(2).
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39349/#review102886
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 65)
<https://reviews.apache.org/r/39349/#comment160695>
The order here seems not correct. We could follow src/Makefile.am https://github.com/apache/mesos/blob/master/src/Makefile.am#L512-L515
```
x/a
x/b
x/c
x/a/b
x/a/c
```
- haosdent huang
On Oct. 15, 2015, 6:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39349/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 6:03 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a Stout wrapper for pipe(2).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/pipe.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pipe.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pipe.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 4bb79fdc161483cfc2b7a7a15e5c3ce62ceb493d
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5
>
> Diff: https://reviews.apache.org/r/39349/diff/
>
>
> Testing
> -------
>
> OS X and CentOS 6
> make && make check
>
>
> Thanks,
>
> James Peach
>
>