[jira] [Commented] (AIRFLOW-3054) Show statements don't work in Hive hook

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625700#comment-16625700 ] 

ASF GitHub Bot commented on AIRFLOW-3054:
-----------------------------------------

aprotopopov opened a new pull request #3940: [AIRFLOW-3054] Add show statements to hql filtering
URL: https://github.com/apache/incubator-airflow/pull/3940
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3054
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Queries which starts with show returning results (like "show tables in default", or "show partitions in default.table_name" and now ingnored with `if` statement. This minor change `if` statements.
   
   ### Tests
   
   - [x] My PR does not need testing for this extremely good reason: minor change
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Show statements don't work in Hive hook 
> ----------------------------------------
>
>                 Key: AIRFLOW-3054
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3054
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hive_hooks
>            Reporter: Anton Protopopov
>            Assignee: Anton Protopopov
>            Priority: Minor
>
> Currently in airflow.hooks.hive_hooks.py in HiveServer2Hook class in _get_results method there are filter for incoming hql:
> source code: https://github.com/apache/incubator-airflow/blob/a79b92ae40c005d8239dfc7711ff44ae69b9c65b/airflow/hooks/hive_hooks.py#L809-L814
> {code:java}
>                 # we only get results of statements that returns
>                 lowered_statement = statement.lower().strip()
>                 if (lowered_statement.startswith('select') or
>                     lowered_statement.startswith('with') or
>                     (lowered_statement.startswith('set') and
>                     '=' not in lowered_statement)):
> {code}
> Queries which starts with show also returning results (like "show tables in default", or "show partitions in default.table_name").
> So I'm thinking it worth to add another statement which starts with "show":
> {code:java}
> lowered_statement.startswith('show')
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)