You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/23 13:10:51 UTC
[GitHub] [thrift] fayalalebrun opened a new pull request, #2586: THRIFT-5559: Make handler public in Rust codegen
fayalalebrun opened a new pull request, #2586:
URL: https://github.com/apache/thrift/pull/2586
<!-- Explain the changes in the pull request below: -->
Previously it was not possible to access the handler object after it was passed to the service processor. This practically prevents the use of any state which is not wrapped by a reference counted pointer. Especially in single-threaded scenarios, this may be undesirable.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ x ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ x ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ x ] Did you squash your changes to a single commit? (not required, but preferred)
- [ x ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ x ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fayalalebrun commented on pull request #2586: THRIFT-5559: Make handler public in Rust codegen
Posted by GitBox <gi...@apache.org>.
fayalalebrun commented on PR #2586:
URL: https://github.com/apache/thrift/pull/2586#issuecomment-1172598548
As far as I know, this change has not been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] allengeorge commented on pull request #2586: THRIFT-5559: Make handler public in Rust codegen
Posted by GitBox <gi...@apache.org>.
allengeorge commented on PR #2586:
URL: https://github.com/apache/thrift/pull/2586#issuecomment-1172475488
[puzzled] I thought I'd merged this a while back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org