You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/10/23 01:26:09 UTC
[PR] Remove ApiMayChange from client transport, request/response association and directive APIs [pekko-http]
pjfanning opened a new pull request, #1364:
URL: https://github.com/apache/pekko-http/pull/1364
### Motivation
`ClientTransport`, `RequestResponseAssociation`, `SimpleRequestResponseAttribute`, the javadsl `anyOf`/`allOf` directive combinators and the `storeUploadedFile`/`storeUploadedFiles`/`fileUploadAll` directives have carried `@ApiMayChange` since Akka HTTP 10.x and have been stable in practice. Akka HTTP 10.6.0 dropped these annotations; 2.0.0 is a natural point for Pekko HTTP to do the same.
### Modification
- Remove `@ApiMayChange` (and the now-unused imports) from the scaladsl/javadsl `ClientTransport`, `RequestResponseAssociation`, `SimpleRequestResponseAttribute`, javadsl `Directives.anyOf`/`allOf`, and scaladsl/javadsl `FileUploadDirectives`.
- Drop the "(Still unstable)" wording from the `ClientTransport` scaladoc.
- Remove the "the API may still change in the future" note from `client-side/client-transport.md`.
### Result
These APIs are declared stable. Annotation and doc-only change; no binary or behavioral impact.
### Tests
- `scalafmt --mode diff-ref=upstream/main`: no changes
- `sbt http-core/compile http/compile`: pass
- `sbt http-core/mimaReportBinaryIssues http/mimaReportBinaryIssues`: pass
- No directional test added: annotation and doc-only change with no behavior to assert
### References
Port of akka/akka-http#4315 (Apache 2.0 now applies, since the Akka HTTP 10.6.0 license change date of 2026-10-23).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove ApiMayChange from client transport, request/response association and directive APIs [pekko-http]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1364:
URL: https://github.com/apache/pekko-http/pull/1364#issuecomment-6370016125
LGTM. Annotation/doc-only removal of `@ApiMayChange`; no binary or behavioral change, and MiMa passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove ApiMayChange from client transport, request/response association and directive APIs [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1364:
URL: https://github.com/apache/pekko-http/pull/1364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org