You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2017/01/30 22:21:02 UTC

Review Request 56100: OOZIE-2782 Input logic wait documentation is confusing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56100/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-2782
    https://issues.apache.org/jira/browse/OOZIE-2782


Repository: oozie-git


Description
-------

OOZIE-2782 Input logic wait documentation is confusing


Diffs
-----

  docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 744f5d9 

Diff: https://reviews.apache.org/r/56100/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 56100: OOZIE-2782 Input logic wait documentation is confusing

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56100/#review163582
-----------------------------------------------------------




docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3464)
<https://reviews.apache.org/r/56100/#comment235039>

    Minimum number of input instances that should be available. This can be used in cases where inputs are optional and the processing can be done on a subset of input instances.



docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (lines 3465 - 3469)
<https://reviews.apache.org/r/56100/#comment235048>

    * *%BLUE% WAIT (in minutes): %ENDCOLOR%* Wait is used to specify the amount of time to continue checking for availability of instances of a particular dataset before moving on to the next dataset defined in a OR condition. The wait time is calculated from the beginning of the nominal time of the action or the action creation time whichever is later. The main purpose of this is to give preference to the primary datasource before checking the secondary datasource. 
    
    Wait when used with min option has a totally different purpose. It is used to specify the additional amount of time to wait and check for more instances after the required minimum set of instances become available. Any additional instances that become available during the wait time are then included.



docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (lines 3471 - 3494)
<https://reviews.apache.org/r/56100/#comment235050>

    For normal wait, the example needs to be moved below to where other examples are.
    
    For min, example already has it. So not required.



docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3512)
<https://reviews.apache.org/r/56100/#comment235051>

    The normal wait example should be added here.
    
    ------------------
    
    <verbatim>
    <input-logic>
        <or name="AorBorC">
            <data-in dataset="A" wait = "60"/>
            <data-in dataset="B" wait = "90"/>
            <data-in dataset="C"/>
        </or>
    </input-logic>
    </verbatim>
    
      With the above expression, it will wait for 60 mins from the nominal time of the action or the action creation time whichever is later for all the instances of dataset A to be available. If it is not available in 60 minutes, then it will start checking for instances of dataset B. If instances of B are not available in another 30 minutes, then it will start checking for dataset C.


- Rohini Palaniswamy


On Jan. 30, 2017, 10:21 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56100/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 10:21 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2782
>     https://issues.apache.org/jira/browse/OOZIE-2782
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-2782 Input logic wait documentation is confusing
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 744f5d9 
> 
> Diff: https://reviews.apache.org/r/56100/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>


Re: Review Request 56100: OOZIE-2782 Input logic wait documentation is confusing

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56100/#review163598
-----------------------------------------------------------


Ship it!




Ship It!

- Rohini Palaniswamy


On Jan. 30, 2017, 11:29 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56100/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 11:29 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2782
>     https://issues.apache.org/jira/browse/OOZIE-2782
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> OOZIE-2782 Input logic wait documentation is confusing
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 744f5d9 
> 
> Diff: https://reviews.apache.org/r/56100/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>


Re: Review Request 56100: OOZIE-2782 Input logic wait documentation is confusing

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56100/
-----------------------------------------------------------

(Updated Jan. 30, 2017, 11:29 p.m.)


Review request for oozie.


Bugs: OOZIE-2782
    https://issues.apache.org/jira/browse/OOZIE-2782


Repository: oozie-git


Description
-------

OOZIE-2782 Input logic wait documentation is confusing


Diffs (updated)
-----

  docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 744f5d9 

Diff: https://reviews.apache.org/r/56100/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 56100: OOZIE-2782 Input logic wait documentation is confusing

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56100/
-----------------------------------------------------------

(Updated Jan. 30, 2017, 11:25 p.m.)


Review request for oozie.


Bugs: OOZIE-2782
    https://issues.apache.org/jira/browse/OOZIE-2782


Repository: oozie-git


Description
-------

OOZIE-2782 Input logic wait documentation is confusing


Diffs (updated)
-----

  docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 744f5d9 

Diff: https://reviews.apache.org/r/56100/diff/


Testing
-------


Thanks,

Purshotam Shah