You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/01/19 20:57:36 UTC

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #856: PARQUET-1964: Properly handle missing/null filter

shangxinli commented on a change in pull request #856:
URL: https://github.com/apache/parquet-mr/pull/856#discussion_r560491067



##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
##########
@@ -1046,6 +1046,8 @@ private ColumnIndexStore getColumnIndexStore(int blockIndex) {
   }
 
   private RowRanges getRowRanges(int blockIndex) {
+    assert FilterCompat

Review comment:
       Do we create an obstacle for testing with NOOP filters?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org