You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:17:22 UTC
Review Request 69963: Handled terminal operation status updates for
orphans.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69963/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Bugs: MESOS-9542
https://issues.apache.org/jira/browse/MESOS-9542
Repository: mesos
Description
-------
When an orphaned operation is transitioned from non-terminal to
terminal, the operation's resources must be added back to the agent's
total resources, while accounting for resource conversion if the
operation is successful.
There is an odd case where an orphan is transitioned to terminal
via an UpdateSlaveMessage (instead of UpdateOperationStatusMessage).
When this happens, the required resource math is actually done by
the agent.
Diffs
-----
src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319
Diff: https://reviews.apache.org/r/69963/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 69963: Handled terminal operation status updates
for orphans.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69963/#review212835
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 13, 2019, 11:24 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69963/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2019, 11:24 p.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-9542
> https://issues.apache.org/jira/browse/MESOS-9542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When an orphaned operation is transitioned from non-terminal to
> terminal, the operation's resources must be added back to the agent's
> total resources, while accounting for resource conversion if the
> operation is successful.
>
> There is an odd case where an orphan is transitioned to terminal
> via an UpdateSlaveMessage (instead of UpdateOperationStatusMessage).
> When this happens, the required resource math is actually done by
> the agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319
>
>
> Diff: https://reviews.apache.org/r/69963/diff/2/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 69963: Handled terminal operation status updates
for orphans.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69963/
-----------------------------------------------------------
(Updated Feb. 13, 2019, 3:24 p.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Changes
-------
Removed AllocationInfo from resources before modifying TotalResources.
Bugs: MESOS-9542
https://issues.apache.org/jira/browse/MESOS-9542
Repository: mesos
Description
-------
When an orphaned operation is transitioned from non-terminal to
terminal, the operation's resources must be added back to the agent's
total resources, while accounting for resource conversion if the
operation is successful.
There is an odd case where an orphan is transitioned to terminal
via an UpdateSlaveMessage (instead of UpdateOperationStatusMessage).
When this happens, the required resource math is actually done by
the agent.
Diffs (updated)
-----
src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319
Diff: https://reviews.apache.org/r/69963/diff/2/
Changes: https://reviews.apache.org/r/69963/diff/1-2/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu