[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf

[GitBox <gi...@apache.org>]

elharo commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546379504



##########
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##########
@@ -33,9 +33,26 @@ under the License.
       <artifactId>commons-lang</artifactId>
       <version>2.5</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-lang3</artifactId>
+      <version>3.11</version>

Review comment:
       This requires Java 8. I think 3.8.1 is the last one we can use. 

##########
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##########
@@ -33,9 +33,26 @@ under the License.
       <artifactId>commons-lang</artifactId>

Review comment:
       weird to have both commons-lang and commons-lang3. This version should be 2.6, fwiw. 

##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -816,12 +816,15 @@ private void changeManifestClasspath( EarModule module, File original, JavaEEVer
             Attribute classPath = mf.getMainSection().getAttribute( "Class-Path" );
             List<String> classPathElements = new ArrayList<String>();
 
+            boolean classPathExisted;

Review comment:
       why past tense? i.e. existed instead of exists?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org