You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2012/07/09 08:39:09 UTC
Review Request: parms should be a copy instead of a reference as locals() is
bound to change over time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5828/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Using the CloudApi didn't work as parms and self were passed on as part of the request. Making parms a copy of the locals() dict will prevent it from being changed later on.
Diffs
-----
cloud-cli/cloudapis/cloud.py 856d811
Diff: https://reviews.apache.org/r/5828/diff/
Testing
-------
api = CloudAPI(server="localhost:8080", apiKey=apiKey, securityKey=secretKey)
print repr(api.createZone(dns1="8.8.8.8", internaldns1="8.8.8.8", name="TestZone",networktype="Advanced"));
Check for correct zone creation in the gui
Thanks,
Hugo Trippaers
Re: Review Request: parms should be a copy instead of a reference as
locals() is bound to change over time
Posted by disheng su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5828/#review9413
-----------------------------------------------------------
Ship it!
Ship It!
- disheng su
On July 9, 2012, 6:39 a.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5828/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 6:39 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Using the CloudApi didn't work as parms and self were passed on as part of the request. Making parms a copy of the locals() dict will prevent it from being changed later on.
>
>
> Diffs
> -----
>
> cloud-cli/cloudapis/cloud.py 856d811
>
> Diff: https://reviews.apache.org/r/5828/diff/
>
>
> Testing
> -------
>
> api = CloudAPI(server="localhost:8080", apiKey=apiKey, securityKey=secretKey)
> print repr(api.createZone(dns1="8.8.8.8", internaldns1="8.8.8.8", name="TestZone",networktype="Advanced"));
>
> Check for correct zone creation in the gui
>
>
> Thanks,
>
> Hugo Trippaers
>
>