You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/08 07:07:56 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #24287:
[WIP][SPARK-27357][SQL] Cast timestamps to/from dates independently from
time zones
cloud-fan commented on a change in pull request #24287: [WIP][SPARK-27357][SQL] Cast timestamps to/from dates independently from time zones
URL: https://github.com/apache/spark/pull/24287#discussion_r272908405
##########
File path: sql/core/src/test/resources/sql-tests/results/predicate-functions.sql.out
##########
@@ -263,7 +263,7 @@ select to_date('2017-03-01') = to_timestamp('2017-03-01 00:00:00')
-- !query 32 schema
struct<(CAST(to_date('2017-03-01') AS TIMESTAMP) = to_timestamp('2017-03-01 00:00:00')):boolean>
-- !query 32 output
-true
+false
Review comment:
shall we change the test case instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org