You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/29 12:08:42 UTC

[GitHub] [ozone] GlenGeng opened a new pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

GlenGeng opened a new pull request #1744:
URL: https://github.com/apache/ozone/pull/1744


   ## What changes were proposed in this pull request?
   
   Use SCMHAManagerImpl and SCMRatisServerImpl instead of MockSCMHAManager and MockRatisServer in MiniOzoneCluster.
   The MockRatisServer and MockSCMHAManager can not fully test the HA code.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4622
   
   ## How was this patch tested?
   
   CI
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi merged pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #1744:
URL: https://github.com/apache/ozone/pull/1744


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #1744:
URL: https://github.com/apache/ozone/pull/1744#issuecomment-756011554


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] amaliujia commented on a change in pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1744:
URL: https://github.com/apache/ozone/pull/1744#discussion_r549916578



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestUtils.java
##########
@@ -475,7 +475,8 @@ public static void quasiCloseContainer(ContainerManagerV2 containerManager,
   public static StorageContainerManager getScmSimple(OzoneConfiguration conf)
       throws IOException, AuthenticationException {
     SCMConfigurator configurator = new SCMConfigurator();
-    configurator.setSCMHAManager(MockSCMHAManager.getInstance(true));
+    // TODO: TestDecommissionAndMaintenance will fail with this setting.
+//    conf.setBoolean(ScmConfigKeys.OZONE_SCM_HA_ENABLE_KEY, true);

Review comment:
       nit: indents before `//`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] amaliujia commented on pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1744:
URL: https://github.com/apache/ozone/pull/1744#issuecomment-752859131


   cc @amaliujia 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GlenGeng commented on a change in pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #1744:
URL: https://github.com/apache/ozone/pull/1744#discussion_r550409759



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestUtils.java
##########
@@ -475,7 +475,8 @@ public static void quasiCloseContainer(ContainerManagerV2 containerManager,
   public static StorageContainerManager getScmSimple(OzoneConfiguration conf)
       throws IOException, AuthenticationException {
     SCMConfigurator configurator = new SCMConfigurator();
-    configurator.setSCMHAManager(MockSCMHAManager.getInstance(true));
+    // TODO: TestDecommissionAndMaintenance will fail with this setting.
+//    conf.setBoolean(ScmConfigKeys.OZONE_SCM_HA_ENABLE_KEY, true);

Review comment:
       done, after rebased from latest HDDS-2823 with fix of https://github.com/apache/ozone/pull/1745




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GlenGeng closed pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

Posted by GitBox <gi...@apache.org>.
GlenGeng closed pull request #1744:
URL: https://github.com/apache/ozone/pull/1744


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] amaliujia commented on pull request #1744: HDDS-4622: Use singe server raft cluster in MiniOzoneCluster.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1744:
URL: https://github.com/apache/ozone/pull/1744#issuecomment-752308572


   Overall LGTM. 
   
   There were comments that I left on https://github.com/apache/ozone/pull/1738 but those comments are addressed in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org