You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2014/03/15 14:00:05 UTC
[jclouds-site] Show labels in the quick news (#65)
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-site label
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/65
-- Commit Summary --
* Show labels in the quick news
-- File Changes --
M _includes/news.md (5)
M news/gsoc2014.md (3)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/65.patch
https://github.com/jclouds/jclouds-site/pull/65.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by jclouds-commentator <no...@github.com>.
Go to http://c8ae738bea49953aed3e-640ccacf7d0d53d54b80b45f4716382c.r76.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37725215
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by Ignasi Barrera <no...@github.com>.
Yes @demobox, I had in mind that labels were mandatory. I've changed the ` ` spaces by a CSS padding, and allowed to use the different label color provider by bootstrap.
Also added some dummy pages just to see how it looks like with the different options. Let's see if it looks nice! :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37756457
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by jclouds-commentator <no...@github.com>.
Go to http://39ca0178d853f7e834e2-d3cdfceae2cede95181a79377a72cfce.r30.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37756488
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by Andrew Phillips <no...@github.com>.
I like the new version:
+1 - good to go for me. Thanks, @nacx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37757796
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by Ignasi Barrera <no...@github.com>.
Thanks @demobox! Merged!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37774316
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #220](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/220/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37756433
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by Ignasi Barrera <no...@github.com>.
Closed #65.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by Andrew Phillips <no...@github.com>.
Visually, looks nice!
With one item, that is. Would be curious to see what it looks like with multiple news items, with labels of different lengths, as well as with news items where some have labels and some don't (or is it the intention to have labels for all news items?).
@nacx: Could you add a dummy commit with additional news items with different-length labels (and one without a label, if that's supposed to be supported) to see what that looks like..?
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37749399
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #219](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/219/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65#issuecomment-37725156
Re: [jclouds-site] Show labels in the quick news (#65)
Posted by Andrew Phillips <no...@github.com>.
> @@ -4,7 +4,10 @@
> {% if page.quicknew %}
> {% if newspresent == true %}<br/>{% endif %}
> {% assign newspresent = true %}
> - <a class="text-primary" href="{{ page.permalink }}"><strong>{{ page.title }}</strong>: {{ page.quicknew }}</a>
> + {% if page.label %}
> + <span class="label label-primary">{{ page.label }}</span>
[minor] I guess there's no way to replace the ` ` with some kind of CSS spacing?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/65/files#r10638117