You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/04 01:01:36 UTC
[GitHub] [incubator-superset] suddjian opened a new pull request #9081:
[dashboard] Fix for dashboard edit modal, loading user list
suddjian opened a new pull request #9081: [dashboard] Fix for dashboard edit modal, loading user list
URL: https://github.com/apache/incubator-superset/pull/9081
### CATEGORY
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The `/users/api/read` endpoint was removed, so this switches to the new `/api/v1/dashboard/related/owners` endpoint, which should also be more accurate regarding which users are returned as potential dashboard owners.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on issue #9081: [dashboard]
Fix for dashboard edit modal, loading user list
Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #9081: [dashboard] Fix for dashboard edit modal, loading user list
URL: https://github.com/apache/incubator-superset/pull/9081#issuecomment-582019788
@dpgaspar What filters do you think should be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9081: [dashboard] Fix for dashboard edit modal, loading user list
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9081: [dashboard] Fix for dashboard edit modal, loading user list
URL: https://github.com/apache/incubator-superset/pull/9081#discussion_r374840016
##########
File path: superset/assets/src/dashboard/components/PropertiesModal.jsx
##########
@@ -203,24 +204,22 @@ class PropertiesModal extends React.PureComponent {
<label className="control-label" htmlFor="owners">
{t('Owners')}
</label>
- {userOptions && (
- <>
- <Select
- name="owners"
- multi
- isLoading={!userOptions}
- value={values.owners}
- options={userOptions || []}
- onChange={this.onOwnersChange}
- disabled={!isOwnersLoaded}
- />
- <p className="help-block">
- {t(
- 'Owners is a list of users who can alter the dashboard.',
- )}
- </p>
- </>
- )}
+ <>
Review comment:
i'm pretty sure this fragment is unneeded now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #9081:
[dashboard] Fix for dashboard edit modal, loading user list
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9081: [dashboard] Fix for dashboard edit modal, loading user list
URL: https://github.com/apache/incubator-superset/pull/9081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9081:
[dashboard] Fix for dashboard edit modal, loading user list
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9081: [dashboard] Fix for dashboard edit modal, loading user list
URL: https://github.com/apache/incubator-superset/pull/9081#issuecomment-581696035
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=h1) Report
> Merging [#9081](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/540df268c286d454ad3980f5c38a972d2163344f?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9081 +/- ##
=========================================
- Coverage 59.45% 59.15% -0.3%
=========================================
Files 369 370 +1
Lines 11752 11818 +66
Branches 2889 2899 +10
=========================================
+ Hits 6987 6991 +4
- Misses 4586 4648 +62
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ssets/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9081/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwuanN4) | `7.27% <0%> (ø)` | :arrow_up: |
| [...sets/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9081/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRGlzcGxheVF1ZXJ5QnV0dG9uLmpzeA==) | `51.38% <0%> (-1.74%)` | :arrow_down: |
| [...rset/assets/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9081/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2V4cGxvcmVSZWR1Y2VyLmpz) | `25% <0%> (-0.93%)` | :arrow_down: |
| [...erset/assets/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9081/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2FjdGlvbnMvZXhwbG9yZUFjdGlvbnMuanM=) | `34.32% <0%> (-0.05%)` | :arrow_down: |
| [...ts/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9081/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUFjdGlvbkJ1dHRvbnMuanN4) | `100% <0%> (ø)` | :arrow_up: |
| [.../assets/src/explore/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9081/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvUHJvcGVydGllc01vZGFsLmpzeA==) | `0% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=footer). Last update [540df26...9e71677](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9081:
[dashboard] Fix for dashboard edit modal, loading user list
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9081: [dashboard] Fix for dashboard edit modal, loading user list
URL: https://github.com/apache/incubator-superset/pull/9081#issuecomment-581696035
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=h1) Report
> Merging [#9081](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/540df268c286d454ad3980f5c38a972d2163344f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9081 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11752 11752
Branches 2889 2888 -1
=======================================
Hits 6987 6987
Misses 4586 4586
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ssets/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9081/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwuanN4) | `7.27% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=footer). Last update [540df26...d3f5efe](https://codecov.io/gh/apache/incubator-superset/pull/9081?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org