[GitHub] [pulsar] Joshhw opened a new pull request #7694: [Issue #7693][AuthorizationService] add missing AuthenticationDataSource to canConsumeAsync method call

[GitBox <gi...@apache.org>]

Joshhw opened a new pull request #7694:
URL: https://github.com/apache/pulsar/pull/7694


   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   Fixes #7693 
   
   ### Motivation
   When trying to chase down a bug in my custom `AuthenticationProvider` I found that when attempting to consume a topic that I wasn't authorized on would fail to produce an unauthorized response while using the `pulsar-client`. I noticed that the `canConsumeAsync` within `AuthorizationService` `canLookUpAsync` doesn't pass along the `AuthenticationDataSource` when it should. My code relied on that to be passed down each time and thus my methods would never return.
   
   ### Modifications
   
   I've added the `AuthenticationDataSource` to the `canConsumeAsync` method.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
     - If a feature is not applicable for documentation, explain why?
       -  it's a bug.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai merged pull request #7694: [Issue #7693][AuthorizationService] add missing AuthenticationDataSource to canConsumeAsync method call

[GitBox <gi...@apache.org>]

jiazhai merged pull request #7694:
URL: https://github.com/apache/pulsar/pull/7694


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org