[GitHub] williaster commented on a change in pull request #4322: [Bug] Resize should trigger chart re-render

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #4322: [Bug] Resize should trigger chart re-render
URL: https://github.com/apache/incubator-superset/pull/4322#discussion_r165237596
 
 

 ##########
 File path: superset/assets/javascripts/chart/Chart.jsx
 ##########
 @@ -87,7 +87,7 @@ class Chart extends React.PureComponent {
   componentDidUpdate(prevProps) {
     if (
         this.props.queryResponse &&
-        this.props.chartStatus === 'success' &&
+        ['success', 'rendered'].indexOf(this.props.chartStatus) > -1 &&
 
 Review comment:
   do you think we should make these `CONSTANTS` to make this less error-prone and ensure consistency between components?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services