You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/09 23:27:22 UTC

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6401: [Rust] Improve the error reporting in build.rs files by using anyhow.

jroesch commented on a change in pull request #6401:
URL: https://github.com/apache/incubator-tvm/pull/6401#discussion_r485975879



##########
File path: rust/tvm-sys/build.rs
##########
@@ -19,22 +19,39 @@
 
 extern crate bindgen;
 
+use std::env;
 use std::path::PathBuf;
 
-use std::env;
+use anyhow::{Context, Result};
 
-fn main() {
+fn main() -> Result<()> {
     let tvm_home = option_env!("TVM_HOME").map(str::to_string).unwrap_or({

Review comment:
       These are from the "old" bindings so I don't even know who wrote all this code originally, but this seems like better behavior. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org