You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Joe McDonnell (Jira)" <ji...@apache.org> on 2024/03/07 04:49:00 UTC
[jira] [Commented] (IMPALA-12445) Native toolchain's redhat9 docker image doesn't have the "file" utility
[ https://issues.apache.org/jira/browse/IMPALA-12445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824251#comment-17824251 ]
Joe McDonnell commented on IMPALA-12445:
----------------------------------------
Merged a fix here:
{noformat}
commit 7f372ff103177834bb5a18bbb877249c0e94da5f
Author: Joe McDonnell <jo...@cloudera.com>
Date: Fri Dec 15 13:04:22 2023 -0800 IMPALA-12445: Install the 'file' utility for Redhat9
The Redhat9 docker image currently doesn't have the
'file' utility installed, which means that the LLVM
build will not strip symbols from LLVM binaries.
This adds 'file' to the list of packages to install
for Redhat 9. It also adds 'file' to the list of
utilities that are expected to be installed.
Testing:
- Built a Redhat 9 docker image and ran a toolchain build
- Built all docker images and verified that the new
check for the 'file' utility passes
Change-Id: If495ed3bdc5c15b796608e723502e44cca5a39ae
Reviewed-on: http://gerrit.cloudera.org:8080/20805
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>{noformat}
> Native toolchain's redhat9 docker image doesn't have the "file" utility
> -----------------------------------------------------------------------
>
> Key: IMPALA-12445
> URL: https://issues.apache.org/jira/browse/IMPALA-12445
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> In the LLVM build, we use the "file" utility to determine which files to strip. On Redhat 9 dockerized builds, this utility is not present so the binaries are not stripped:
> {noformat}
> 11:43:33 impala-toolchain-redhat9: Apply patches up to 7
> 11:43:33 impala-toolchain-redhat9: Applying patch 1.../mnt/source/llvm/llvm-5.0.1-patches/0001-PATCH-Fix-run-clang-tidy.py-s-output.patch
> 11:43:33 impala-toolchain-redhat9: Applying patch 2.../mnt/source/llvm/llvm-5.0.1-patches/0002-PATCH-Fix-for-missing-sys-ustat.patch
> 11:43:33 impala-toolchain-redhat9: Applying patch 3.../mnt/source/llvm/llvm-5.0.1-patches/0003-PATCH-Fix-for-large-code-model-on-aarch64.patch
> 11:43:33 impala-toolchain-redhat9: Applying patch 4.../mnt/source/llvm/llvm-5.0.1-patches/0004-PATCH-glibc-libsanitizer.patch
> 11:43:33 impala-toolchain-redhat9: Applying patch 5.../mnt/source/llvm/llvm-5.0.1-patches/0005-PATCH-Fix-lli-compilation-on-gcc8.patch
> 11:43:33 impala-toolchain-redhat9: Applying patch 6.../mnt/source/llvm/llvm-5.0.1-patches/0006-PATCH-Remove-include-for-cyclades.h-on-redhat9.patch
> 11:43:33 impala-toolchain-redhat9: Applying patch 7.../mnt/source/llvm/llvm-5.0.1-patches/0007-PATCH-Fix-SetAlternativeSignalStack-for-glibc-2.34.patch
> 11:43:33 impala-toolchain-redhat9: All required patches applied.
> 11:43:33 impala-toolchain-redhat9: /mnt/source/llvm/build-source-tarball.sh: line 186: file: command not found
> 11:43:33 impala-toolchain-redhat9: /mnt/source/llvm/build-source-tarball.sh: line 186: file: command not found
> ...{noformat}
> We should modify the Redhat 9 docker build and also add an assert in docker/all/assert-dependencies-present.py.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org