[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #12099: Refactor shadow rule and modify shadow value generic type.

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #12099:
URL: https://github.com/apache/shardingsphere/pull/12099#discussion_r698274038



##########
File path: shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/algorithm/shadow/column/ColumnRegexMatchShadowAlgorithm.java
##########
@@ -81,11 +81,11 @@ private void checkOperation() {
     }
     
     @Override
-    public boolean isShadow(final Collection<String> shadowTableNames, final PreciseColumnShadowValue<String> shadowValue) {
+    public boolean isShadow(final Collection<String> shadowTableNames, final PreciseColumnShadowValue<Comparable<?>> shadowValue) {
         boolean containTable = shadowTableNames.contains(shadowValue.getLogicTableName());

Review comment:
       why containTable is not isContainTable or why others start with `is`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org