You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/30 21:55:57 UTC

[GitHub] [kafka] gharris1727 opened a new pull request #8594: KAFKA-9830: Backport "Implement AutoCloseable in ErrorReporter and subclasses"

gharris1727 opened a new pull request #8594:
URL: https://github.com/apache/kafka/pull/8594


   This is a backport of #8442 for the 2.0 and 2.1 branches.
   
   In these versions, producer.close(Duration) does not exist, and producer.close(long, TimeUnit) is not deprecated. The tests are adjusted to use the older API.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] gharris1727 commented on pull request #8594: KAFKA-9830: Backport "Implement AutoCloseable in ErrorReporter and subclasses"

Posted by GitBox <gi...@apache.org>.
gharris1727 commented on pull request #8594:
URL: https://github.com/apache/kafka/pull/8594#issuecomment-622136830


   cc @kkonstantine for review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kkonstantine commented on pull request #8594: KAFKA-9830: Backport "Implement AutoCloseable in ErrorReporter and subclasses"

Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8594:
URL: https://github.com/apache/kafka/pull/8594#issuecomment-622269313


   Backporting https://github.com/apache/kafka/pull/8442 up to `2.2` seems actually sufficient for this issue (not CVE/data loss related). Therefore, I'll go ahead and close this PR. We may reopen if we find evidence that such backporting is required. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org