[GitHub] [ozone] swamirishi commented on a diff in pull request #5065: HDDS-8896. Remove -skipTrash option from sh key delete command.

["swamirishi (via GitHub)" <gi...@apache.org>]

swamirishi commented on code in PR #5065:
URL: https://github.com/apache/ozone/pull/5065#discussion_r1265599366


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/DeleteKeyHandler.java:
##########
@@ -83,7 +78,7 @@ private void deleteFSOKey(OzoneBucket bucket, String keyName)
 
     // If Bucket layout is FSO and Trash is enabled
     // In this case during delete operation move key to trash
-    if (trashInterval > 0 && !skipTrash &&
+    if (trashInterval > 0 &&

Review Comment:
   Correct me if I am wrong, if --skipTrash is passed here. One might know skipTrash is supported. Shouldn't we just throw an exception saying --skipTrash is not supported instead of removing the whole config?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org