You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/12/08 23:16:29 UTC
[kudu-CR] catalog-manager: fix some duplicated error messages
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8805
to review the following change.
Change subject: catalog-manager: fix some duplicated error messages
......................................................................
catalog-manager: fix some duplicated error messages
A few places in the catalog manager were using Status::CloneAndPrepend
improperly. These are really hard to trigger conditions, so it's rare
they'd be seen in the wild.
Change-Id: I41b54c6f003d81c53c648370b08ed5af2be58b64
---
M src/kudu/master/catalog_manager.cc
1 file changed, 5 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/8805/1
--
To view, visit http://gerrit.cloudera.org:8080/8805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41b54c6f003d81c53c648370b08ed5af2be58b64
Gerrit-Change-Number: 8805
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] catalog-manager: fix some duplicated error messages
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8805 )
Change subject: catalog-manager: fix some duplicated error messages
......................................................................
catalog-manager: fix some duplicated error messages
A few places in the catalog manager were using Status::CloneAndPrepend
improperly. These are really hard to trigger conditions, so it's rare
they'd be seen in the wild.
Change-Id: I41b54c6f003d81c53c648370b08ed5af2be58b64
Reviewed-on: http://gerrit.cloudera.org:8080/8805
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/catalog_manager.cc
1 file changed, 5 insertions(+), 10 deletions(-)
Approvals:
Hao Hao: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41b54c6f003d81c53c648370b08ed5af2be58b64
Gerrit-Change-Number: 8805
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] catalog-manager: fix some duplicated error messages
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8805 )
Change subject: catalog-manager: fix some duplicated error messages
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41b54c6f003d81c53c648370b08ed5af2be58b64
Gerrit-Change-Number: 8805
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 08 Dec 2017 23:46:40 +0000
Gerrit-HasComments: No
[kudu-CR] catalog-manager: fix some duplicated error messages
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8805 )
Change subject: catalog-manager: fix some duplicated error messages
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41b54c6f003d81c53c648370b08ed5af2be58b64
Gerrit-Change-Number: 8805
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 08 Dec 2017 23:55:11 +0000
Gerrit-HasComments: No