You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/06/28 14:57:05 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #24545: Revert "fix: enable strong session protection by default (#24256)"
michael-s-molina opened a new pull request, #24545:
URL: https://github.com/apache/superset/pull/24545
### SUMMARY
This PR reverts https://github.com/apache/superset/pull/24256 due to problems with the login and Alerts & Reports. It's not a complete revert because I preserved most of the documentation added to `security.mdx` and only reverted the part about `SESSION_PROTECTION`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24545: fix: Revert enable strong session protection by default (#24256)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24545:
URL: https://github.com/apache/superset/pull/24545#issuecomment-1611615142
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24545](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (01ab3cb) into [master](https://app.codecov.io/gh/apache/superset/commit/750113441cd0160ed53e918253a7256466028ac0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7501134) will **decrease** coverage by `10.86%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 01ab3cb differs from pull request most recent head fa8f3fa. Consider uploading reports for the commit fa8f3fa to get more accurate results
```diff
@@ Coverage Diff @@
## master #24545 +/- ##
===========================================
- Coverage 68.93% 58.07% -10.86%
===========================================
Files 1903 1903
Lines 74027 74025 -2
Branches 8118 8118
===========================================
- Hits 51027 42990 -8037
- Misses 20889 28924 +8035
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.78% <50.00%> (?)` | |
| python | `60.59% <50.00%> (-22.60%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.64% <50.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/DropdownContainer/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25Db250YWluZXIvaW5kZXgudHN4) | `65.00% <ø> (ø)` | |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `69.73% <ø> (ø)` | |
| [superset/charts/commands/warm\_up\_cache.py](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3dhcm1fdXBfY2FjaGUucHk=) | `32.50% <ø> (-65.00%)` | :arrow_down: |
| [superset/config.py](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.37% <ø> (-0.60%)` | :arrow_down: |
| [superset/databases/api.py](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `52.16% <0.00%> (-37.75%)` | :arrow_down: |
| [superset/datasets/commands/warm\_up\_cache.py](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvd2FybV91cF9jYWNoZS5weQ==) | `52.17% <ø> (-47.83%)` | :arrow_down: |
| [superset/initialization/\_\_init\_\_.py](https://app.codecov.io/gh/apache/superset/pull/24545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `91.35% <100.00%> (-0.03%)` | :arrow_down: |
... and [297 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24545/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24545: fix: Revert enable strong session protection by default (#24256)
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24545:
URL: https://github.com/apache/superset/pull/24545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org