[jira] [Work logged] (BEAM-8824) Add support for allowed lateness in python sdk

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-8824?focusedWorklogId=352246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352246 ]

ASF GitHub Bot logged work on BEAM-8824:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Dec/19 21:52
            Start Date: 02/Dec/19 21:52
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on pull request #10216: [BEAM-8824] Add support to allow specify window allowed_lateness in python sdk
URL: https://github.com/apache/beam/pull/10216#discussion_r352877739
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/trigger_test.py
 ##########
 @@ -718,6 +719,9 @@ def fire_timers():
         output = [
             _windowed_value_info(wv)
             for wv in driver.process_elements(state, bundle, watermark)]
+        # ignore WindowValues with expired window in output
+        output = [wvi for wvi in output
+                  if wvi['window'][1] + allowed_lateness >= watermark]
 
 Review comment:
   Above we do filtering before calling driver.process_elements. Here we do filtering after, which seems inconsistent. Any reason allowed_lateness shouldn't be used within `driver.process_elements` (which takes windowing as a parameter) to consistently do the right thing? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 352246)
    Time Spent: 2h 40m  (was: 2.5h)

> Add support for allowed lateness in python sdk
> ----------------------------------------------
>
>                 Key: BEAM-8824
>                 URL: https://issues.apache.org/jira/browse/BEAM-8824
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Yichi Zhang
>            Assignee: Yichi Zhang
>            Priority: Major
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)