You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/01/03 12:13:04 UTC
Review Request 55136: AM sizing for LLAP - min container size changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55136/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-19338
https://issues.apache.org/jira/browse/AMBARI-19338
Repository: ambari
Description
-------
Currently, AMs are sized too big for LLAP (especially with small setups). Better defaults are needed, but min container size has to change for that.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 77ed527
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 6f91ca8
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 4b3397f
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py beebe28
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 378522e
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py a7ccdfe
Diff: https://reviews.apache.org/r/55136/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [5.041s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.006s]
[INFO] Ambari Views ...................................... SUCCESS [3.302s]
[INFO] utility ........................................... SUCCESS [1.623s]
[INFO] ambari-metrics .................................... SUCCESS [0.350s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.392s]
[INFO] Ambari Server ..................................... SUCCESS [1:25.020s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Dmytro Sen
Re: Review Request 55136: AM sizing for LLAP - min container size
changes
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On \u042f\u043d\u0432. 3, 2017, 5:55 \u043f.\u043f., Sid Wagle wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, line 129
> > <https://reviews.apache.org/r/55136/diff/1/?file=1595935#file1595935line129>
> >
> > Does the stack have correct default of 1024?
It's 512 in stack's yarn-site.xml but always overridden by stack advisor. After committing this patch, it won't greater than 1024 mb
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55136/#review160401
-----------------------------------------------------------
On \u042f\u043d\u0432. 3, 2017, 12:13 \u043f.\u043f., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55136/
> -----------------------------------------------------------
>
> (Updated \u042f\u043d\u0432. 3, 2017, 12:13 \u043f.\u043f.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19338
> https://issues.apache.org/jira/browse/AMBARI-19338
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, AMs are sized too big for LLAP (especially with small setups). Better defaults are needed, but min container size has to change for that.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 77ed527
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 6f91ca8
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 4b3397f
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py beebe28
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 378522e
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py a7ccdfe
>
> Diff: https://reviews.apache.org/r/55136/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [5.041s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.006s]
> [INFO] Ambari Views ...................................... SUCCESS [3.302s]
> [INFO] utility ........................................... SUCCESS [1.623s]
> [INFO] ambari-metrics .................................... SUCCESS [0.350s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.392s]
> [INFO] Ambari Server ..................................... SUCCESS [1:25.020s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 55136: AM sizing for LLAP - min container size
changes
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55136/#review160401
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py (line 129)
<https://reviews.apache.org/r/55136/#comment231530>
Does the stack have correct default of 1024?
- Sid Wagle
On Jan. 3, 2017, 12:13 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55136/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 12:13 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19338
> https://issues.apache.org/jira/browse/AMBARI-19338
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, AMs are sized too big for LLAP (especially with small setups). Better defaults are needed, but min container size has to change for that.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 77ed527
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 6f91ca8
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 4b3397f
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py beebe28
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 378522e
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py a7ccdfe
>
> Diff: https://reviews.apache.org/r/55136/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [5.041s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.006s]
> [INFO] Ambari Views ...................................... SUCCESS [3.302s]
> [INFO] utility ........................................... SUCCESS [1.623s]
> [INFO] ambari-metrics .................................... SUCCESS [0.350s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.392s]
> [INFO] Ambari Server ..................................... SUCCESS [1:25.020s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 55136: AM sizing for LLAP - min container size
changes
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55136/#review160406
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Jan. 3, 2017, 12:13 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55136/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 12:13 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19338
> https://issues.apache.org/jira/browse/AMBARI-19338
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, AMs are sized too big for LLAP (especially with small setups). Better defaults are needed, but min container size has to change for that.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 77ed527
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 6f91ca8
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 4b3397f
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py beebe28
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 378522e
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py a7ccdfe
>
> Diff: https://reviews.apache.org/r/55136/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [5.041s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.006s]
> [INFO] Ambari Views ...................................... SUCCESS [3.302s]
> [INFO] utility ........................................... SUCCESS [1.623s]
> [INFO] ambari-metrics .................................... SUCCESS [0.350s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.392s]
> [INFO] Ambari Server ..................................... SUCCESS [1:25.020s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Dmytro Sen
>
>