You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@annotator.apache.org by ra...@apache.org on 2020/05/15 07:19:32 UTC
[incubator-annotator] branch master updated (00eb8cd -> 6e668f7)
This is an automated email from the ASF dual-hosted git repository.
randall pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-annotator.git.
from 00eb8cd Merge pull request #76 from apache/clone-dist
new 39cdf61 Separate lint and test make targets
new 3c113f5 Remove extraneous semicolon
new 6e668f7 Do not fix lint errors with yarn lint
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
Makefile | 9 ++++++++-
package.json | 2 +-
web/demo/index.js | 2 +-
3 files changed, 10 insertions(+), 3 deletions(-)
[incubator-annotator] 01/03: Separate lint and test make targets
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
randall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-annotator.git
commit 39cdf61c342d24832254de1a7844b4b6b35989a3
Author: Randall Leeds <ra...@apache.org>
AuthorDate: Thu May 14 22:58:28 2020 -0700
Separate lint and test make targets
---
Makefile | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 498828b..982f24a 100644
--- a/Makefile
+++ b/Makefile
@@ -41,7 +41,14 @@ clean:
@yarn run clean
.PHONY: check
-check: build
+check: lint test
+
+.PHONY: lint
+lint: build
+ @yarn lint
+
+.PHONY: test
+test: build
@yarn test
ifeq ($(vsn_tag),)
[incubator-annotator] 02/03: Remove extraneous semicolon
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
randall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-annotator.git
commit 3c113f5bdff13254cc69146dc0f67b654884787e
Author: Randall Leeds <ra...@apache.org>
AuthorDate: Thu May 14 22:58:51 2020 -0700
Remove extraneous semicolon
---
web/demo/index.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/demo/index.js b/web/demo/index.js
index 47f7f30..9f59fca 100644
--- a/web/demo/index.js
+++ b/web/demo/index.js
@@ -118,7 +118,7 @@ async function anchor(selector) {
}
info.innerText = JSON.stringify(selector, null, 2);
-};
+}
async function describeSelection() {
const selection = document.getSelection();
[incubator-annotator] 03/03: Do not fix lint errors with yarn lint
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
randall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-annotator.git
commit 6e668f7a098481d44425ed24cbec752bdf7efd4d
Author: Randall Leeds <ra...@apache.org>
AuthorDate: Thu May 14 22:59:55 2020 -0700
Do not fix lint errors with yarn lint
Leave it to the user to run linting with automatic fixing to avoid any
confusion that might arise from the command generating unstaged changes.
---
package.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package.json b/package.json
index 1ed4a05..f081fbe 100644
--- a/package.json
+++ b/package.json
@@ -21,7 +21,7 @@
"build:esm": "cross-env BABEL_ENV=esm yarn build:babel -d esm src",
"build:misc": "lerna exec -- cp ../../LICENSE ../../NOTICE .",
"clean": "lerna exec -- rimraf LICENSE NOTICE esm lib",
- "lint": "eslint --fix --quiet .",
+ "lint": "eslint .",
"prepare": "lerna run prepare",
"prepublishOnly": "yarn run build",
"start": "yarn run web:server",