You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Weiwei Yang (JIRA)" <ji...@apache.org> on 2019/01/07 02:07:00 UTC

[jira] [Comment Edited] (YARN-9037) [CSI] Ignore volume resource in resource calculators based on tags

    [ https://issues.apache.org/jira/browse/YARN-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735384#comment-16735384 ] 

Weiwei Yang edited comment on YARN-9037 at 1/7/19 2:06 AM:
-----------------------------------------------------------

Hi [~sunilg]

I think the patch works as designed, thanks.

I've done some changes based on your patch, as following
 # Added another end to end UT in {{TestVolumeProcessor}} to verify the container allocation with volumes
 # Renamed to EXTERNAL_VOLUME_RESOURCE_TAG to represent tag name for csi volumes in ResourceUtils
 # Modified the value of volume resource in {{testMultipleOpsForResourcesWithTags}} to avoid the possibility of verification scenario slipping away

Please take a look, thanks


was (Author: cheersyang):
Hi [~sunilg]

I think the patch works as designed, thanks.

I've done some changes based on your patch, as following
 # Added another end to end UT in \{{TestVolumeProcessor}} to verify the container allocation with volumes
 # Renamed to EXTERNAL_VOLUME_RESOURCE_TAG to represent tag name for csi volumes in \{{ResourceUtils}}
 # Modified the value of volume resource in \{{testMultipleOpsForResourcesWithTags}} to avoid the possibility of verification scenario slipping away

Please take a look, thanks

> [CSI] Ignore volume resource in resource calculators based on tags
> ------------------------------------------------------------------
>
>                 Key: YARN-9037
>                 URL: https://issues.apache.org/jira/browse/YARN-9037
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Sunil Govindan
>            Priority: Major
>              Labels: CSI
>         Attachments: YARN-9037-002.patch, YARN-9037.001.patch, YARN-9037.003.patch, YARN-9037.004.patch
>
>
> The pre-provisioned volume is specified as a resource, but such resource is different comparing to what is managed now in YARN, e.g memory, vcores. They are constrained by 3rd party storage systems, so it looks more like an unmanaged resource. In such case, we need to ignore the resource calculation over them in the resource calculators. This can be done based on the resource tags.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org