You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/06 03:28:07 UTC

[GitHub] [tvm] soodoshll opened a new pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

soodoshll opened a new pull request #9204:
URL: https://github.com/apache/tvm/pull/9204


   Greetings. I encountered a problem when trying translating Pytorch models into relay. `relay.nn.bias_add` has a default `axis=1`, which is inconsistent with [linear](https://pytorch.org/docs/stable/generated/torch.nn.functional.linear.html#torch.nn.functional.linear) in PyTorch, which always adds bias to the last dimension. So it is necessary to explicitly assign `axis=-1` here.
   
   Thanks @spectrometerHBH for helping debug. cc @junrushao1994 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9204:
URL: https://github.com/apache/tvm/pull/9204


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9204:
URL: https://github.com/apache/tvm/pull/9204


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9204:
URL: https://github.com/apache/tvm/pull/9204#issuecomment-937581219


   Thanks @soodoshll 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9204:
URL: https://github.com/apache/tvm/pull/9204#issuecomment-935434890


   Thanks, can you add a test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] soodoshll commented on pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

Posted by GitBox <gi...@apache.org>.
soodoshll commented on pull request #9204:
URL: https://github.com/apache/tvm/pull/9204#issuecomment-937402492


   @masahi Hi, test is also fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] soodoshll commented on pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

Posted by GitBox <gi...@apache.org>.
soodoshll commented on pull request #9204:
URL: https://github.com/apache/tvm/pull/9204#issuecomment-937402492


   @masahi Hi, test is also fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #9204: [PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9204:
URL: https://github.com/apache/tvm/pull/9204#issuecomment-937581219


   Thanks @soodoshll 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org