You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by thomasbeauvais <gi...@git.apache.org> on 2017/11/09 13:34:31 UTC

[GitHub] logging-log4j2 pull request #128: LOG4J2-2110 adding a ServletContext parame...

GitHub user thomasbeauvais opened a pull request:

    https://github.com/apache/logging-log4j2/pull/128

    LOG4J2-2110 adding a ServletContext parameter to allow the contextIni…

    Please refer to https://issues.apache.org/jira/browse/LOG4J2-2110
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thomasbeauvais/logging-log4j2 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit cb0e2020b6106431a53dea497ca8415b1567b2c1
Author: itonics-tbeauvais <th...@itonics.de>
Date:   2017-11-09T13:30:43Z

    LOG4J2-2110 adding a ServletContext parameter to allow the contextInitialized to be skipped and still work in the contextDestroyed

----


---

[GitHub] logging-log4j2 issue #128: LOG4J2-2110 adding a ServletContext parameter to ...

Posted by jvz <gi...@git.apache.org>.

Github user jvz commented on the issue:

    https://github.com/apache/logging-log4j2/pull/128
  
    Could you reformat this using spaces instead of tabs?


---

[GitHub] logging-log4j2 issue #128: LOG4J2-2110 adding a ServletContext parameter to ...

Posted by rgoers <gi...@git.apache.org>.

Github user rgoers commented on the issue:

    https://github.com/apache/logging-log4j2/pull/128
  
    I'd be hesitant to apply this without understanding why contextInitialized isn't being called.


---

[GitHub] logging-log4j2 issue #128: LOG4J2-2110 adding a ServletContext parameter to ...

Posted by thomasbeauvais <gi...@git.apache.org>.

Github user thomasbeauvais commented on the issue:

    https://github.com/apache/logging-log4j2/pull/128
  
    I have fixed the whitespace. 
    
    What can I do to help you figure out why it wasn't being initialized? A colleague and myself spent a couple hours debugging to find this. It very strange behavior and seems to have been there for quite sometime. We have added this exact fix, and now everything is started and stopped properly each time.
    
    Out problem was that we are starting up a few of resources. Without this fix, we noticed leaks on redeployment. The stop was never call since the {{servletContext}} in the {{Log4jServletContextListener}} is always {{null}} no matter what you do. 


---