You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2015/11/18 15:03:55 UTC
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1378
[FLINK-2686] Show exchange mode in JSON plan
Extends the PlanJSONDumpGenerator to also include the Data Exchange mode. It will be shown like this:
```
...
"parallelism": "2",
"predecessors": [
{"id": 5, "ship_strategy": "Forward", "exchange_mode": "PIPELINED"}
],
"driver_strategy": "Map",
...
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 2686_json_exchange
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1378
----
commit 1ce8aa73ef773f20230d272459d5f05f71fef369
Author: zentol <ch...@apache.org>
Date: 2015-11-18T13:52:48Z
[FLINK-2686] Show exchange mode in JSON plan
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1378#issuecomment-157726455
Ah, right you are...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1378#issuecomment-159368106
Merging this once Travis passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1378#issuecomment-157724392
The JSON plan generation has actually two points now (that we should try to consolidate). The other one is on "https://github.com/apache/flink/blob/6e0e67d2e0d5180d6fba492e8ab9cc8fb18fdf68/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonPlanGenerator.java" and deals with attaching the JSON plan to every JobGraph so that the runtime dashboard can draw a graph. That plan is a bit different then the optimizer JSON (because it is not iteration aware and chained tasks are only one operator any more), but otherwise follows similar logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1378#issuecomment-157726222
it appears that one already includes the exchange mode.
```
...
if (operatorLevelCaching != null) {
gen.writeStringField("caching", operatorLevelCaching);
}
gen.writeStringField("exchange", edge.getSource().getResultType().name().toLowerCase());
gen.writeEndObject();
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1378#issuecomment-158054893
Looks good to merge.
Think this need a followup where the exchange type is displayed in the plan visualizer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1378
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2686] Show exchange mode in JSON plan
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1378#issuecomment-158060613
Visualization for this would be great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---