You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/12 15:01:36 UTC
[GitHub] [spark] gaborgsomogyi opened a new pull request #27892:
[MINOR][TESTS] Upgrdade docker-client version to 8.14.1
gaborgsomogyi opened a new pull request #27892: [MINOR][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892
### What changes were proposed in this pull request?
Upgrdade `docker-client` version.
### Why are the changes needed?
`docker-client` what Spark uses is super old. Snippet from the project page:
```
Spotify no longer uses recent versions of this project internally.
The version of docker-client we're using is whatever helios has in its pom.xml. => 8.14.1
```
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
`build/mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.12 -Dtest=none -DwildcardSuites=org.apache.spark.sql.jdbc.DB2IntegrationSuite test`
`build/mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.12 -Dtest=none -DwildcardSuites=org.apache.spark.sql.jdbc.MsSqlServerIntegrationSuite test`
`build/mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.12 -Dtest=none -DwildcardSuites=org.apache.spark.sql.jdbc.PostgresIntegrationSuite test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391748860
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
Hi, @gaborgsomogyi . They are using [shaded](https://github.com/spotify/helios/blob/master/pom.xml#L143) version, aren't they? Could you change like them to follow correctly (if we decide to follow them)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598342398
**[Test build #119718 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119718/testReport)** for PR 27892 at commit [`55731a7`](https://github.com/apache/spark/commit/55731a762fbb5cb56ec2d42904429b22738b53b4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391758008
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
BTW, `com.spotify:docker-client:jar:shaded` is a correct message? `shaded` is a classifier, not a version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27892: [MINOR][TESTS] Upgrdade
docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27892: [MINOR][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598240035
**[Test build #119718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119718/testReport)** for PR 27892 at commit [`55731a7`](https://github.com/apache/spark/commit/55731a762fbb5cb56ec2d42904429b22738b53b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391755199
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
Tried it already but getting this:
```
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for com.spotify:docker-client:jar:shaded is missing. @ line 49, column 17
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project org.apache.spark:spark-docker-integration-tests_2.12:3.1.0-SNAPSHOT (/Users/gaborsomogyi/spark/external/docker-integration-tests/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for com.spotify:docker-client:jar:shaded is missing. @ line 49, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
```
Why do we need shaded version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27892:
[SPARK-31135][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27892: [SPARK-31135][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598284032
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391748860
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
Hi, @gaborgsomogyi . They are using `shaded` version, aren't they? Could you change like them to follow correctly (if we decide to follow them)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598792586
Seems OK if it's going to just affect tests and tests work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-599408471
Thanks @dongjoon-hyun @srowen taking care! Also double checked 3.0 branch and works fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598343381
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27892:
[SPARK-31135][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27892: [SPARK-31135][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598280861
Filed https://issues.apache.org/jira/browse/SPARK-31135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27892: [MINOR][TESTS]
Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27892: [MINOR][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598237391
cc @dongjoon-hyun since you know this area well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598386422
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27892: [MINOR][TESTS]
Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27892: [MINOR][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598273767
Thank you for pinging me, @gaborgsomogyi . Shall we have a JIRA ID?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391758008
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
BTW, `com.spotify:docker-client:jar:shaded` is a correct message? `shaded` is a classifier, not a version. It looks weird to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391774521
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
> BTW, com.spotify:docker-client:jar:shaded is a correct message?
That was the flag to me as well that I must have local problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598386422
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598240035
**[Test build #119718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119718/testReport)** for PR 27892 at commit [`55731a7`](https://github.com/apache/spark/commit/55731a762fbb5cb56ec2d42904429b22738b53b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391770704
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
Had some problem with my repo setup but resolved and re-tested. Pushing it soon...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598310698
**[Test build #119722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119722/testReport)** for PR 27892 at commit [`9dde9ed`](https://github.com/apache/spark/commit/9dde9ed26507530706fcf88abd58829dfefdfb93).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598386429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119722/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598343381
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598343390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119718/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r391757187
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
This is effectively a version upgrade in `dockeer-integration-tests/pom.xml`. We don't know what it brings. We have a history. Please see SPARK-29546.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598385506
**[Test build #119722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119722/testReport)** for PR 27892 at commit [`9dde9ed`](https://github.com/apache/spark/commit/9dde9ed26507530706fcf88abd58829dfefdfb93).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27892: [MINOR][TESTS]
Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27892: [MINOR][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598279722
@dongjoon-hyun thought it can be minor. Sure, creating one...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598386429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119722/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#discussion_r392592942
##########
File path: pom.xml
##########
@@ -931,7 +931,7 @@
<dependency>
<groupId>com.spotify</groupId>
<artifactId>docker-client</artifactId>
- <version>5.0.2</version>
+ <version>8.14.1</version>
Review comment:
Do we have any concerns back porting this into 3.0? any downside?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598343390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119718/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27892: [MINOR][TESTS]
Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27892: [MINOR][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598240415
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598310698
**[Test build #119722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119722/testReport)** for PR 27892 at commit [`9dde9ed`](https://github.com/apache/spark/commit/9dde9ed26507530706fcf88abd58829dfefdfb93).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27892:
[SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27892: [SPARK-31135][BUILD][TESTS] Upgrdade docker-client version to 8.14.1
URL: https://github.com/apache/spark/pull/27892#issuecomment-598240415
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org