You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2018/11/21 19:15:36 UTC

[GitHub] keith-turner commented on a change in pull request #237: Muchos can optionally set up Docker & Swarm

keith-turner commented on a change in pull request #237: Muchos can optionally set up Docker & Swarm
URL: https://github.com/apache/fluo-muchos/pull/237#discussion_r235509397
 
 

 ##########
 File path: README.md
 ##########
 @@ -101,6 +101,11 @@ at `http://<MESOS_MASTER_NODE>:8080/`.
 5. `client` - Used to specify a client node where no services are run but libraries are installed to
 run Accumulo/Hadoop clients.
 
+6. `swarmmanager` - If specified, a Swarm manager will be run on this node and swarm workers will
+be started on all worker nodes (except the swarm manager node). It is recommended that the swarm
 
 Review comment:
   Saying `except the swarm manager node` seems to contradict later sentences.  Could write :
   
   ```
   Sets up [docker swarm] with the manager on this node and joins all worker nodes to this swarm.  When this is set docker is installed on all worker nodes.  It is recommended that ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services