[GitHub] [activemq-artemis] franz1981 edited a comment on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive

[GitBox <gi...@apache.org>]

franz1981 edited a comment on issue #3068: ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive
URL: https://github.com/apache/activemq-artemis/pull/3068#issuecomment-609951227
 
 
   I've sent a second commit that (assuming that I've correctly understood the original logic) simplify the current logic. @clebertsuconic @jbertram @andytaylor please take a look at the 2 commits separately, if I've misunderstood how `QuorumVoteServerConnect` is supposed to work...
   
   In addition: I see that we should check for `targetNodeId` vs `ServerConnectVote::getNodeId` on `QuorumVoteServerConnect::vote` too (probably).
   
   `QuorumFailOverTest::testQuorumVotingLiveNotDead` is failing with this, so probably there is something in the original logic that I haven't honored.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services