You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/10/01 20:26:33 UTC
Review Request 26214: Add apr and svn to configure.ac
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Able to build with OSX and Ubuntu 14.04.
(Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
configure.ac 86d448c
src/Makefile.am 27c42df
Diff: https://reviews.apache.org/r/26214/diff/
Testing
-------
make
Thanks,
Timothy Chen
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55104
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp
<https://reviews.apache.org/r/26214/#comment95465>
Had to change these calls since it was giving me a deprecated error when installing libraries via apt-get or brew. We should use the updated calls anyway.
- Timothy Chen
On Oct. 1, 2014, 6:26 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 6:26 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55106
-----------------------------------------------------------
Bad patch!
Reviews applied: [24535, 24536, 24537, 26214]
Failed command: ./configure
Error:
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
configure: Setting up build environment for x86_64 linux-gnu
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking if compiling with clang... no
configure: GCC version: 4.8
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for backtrace in -lunwind... no
checking for gzread in -lz... yes
checking for curl_global_init in -lcurl... yes
checking for apr_initialize in -lapr-1... no
configure: error: cannot find libapr-1
-------------------------------------------------------------------
libapr-1 is required for mesos to build.
-------------------------------------------------------------------
- Mesos ReviewBot
On Oct. 1, 2014, 6:26 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 6:26 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55532
-----------------------------------------------------------
Ship it!
configure.ac
<https://reviews.apache.org/r/26214/#comment95907>
Let's avoid the extra APR_CFLAGS variable and just set CPPFLAGS in both the branches. Same below with SVN_CFLAGS (and in the libprocess configure.ac too).
- Benjamin Hindman
On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55607
-----------------------------------------------------------
Bad patch!
Reviews applied: [24535, 24536, 24537, 26214]
Failed command: ./configure
Error:
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
configure: Setting up build environment for x86_64 linux-gnu
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking if compiling with clang... no
configure: GCC version: 4.8
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for backtrace in -lunwind... no
checking for gzread in -lz... yes
checking for curl_global_init in -lcurl... yes
checking for apr_initialize in -lapr-1... yes
checking for svn_stringbuf_create_ensure in -lsvn_subr-1... no
configure: error: cannot find libsvn_subr-1
-------------------------------------------------------------------
libsubversion-1 is required for mesos to build.
-------------------------------------------------------------------
- Mesos ReviewBot
On Oct. 6, 2014, 7:04 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 7:04 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac da1c82d
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55628
-----------------------------------------------------------
Bad patch!
Reviews applied: [24535, 24536, 24537, 26214]
Failed command: ./configure
Error:
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
configure: Setting up build environment for x86_64 linux-gnu
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking if compiling with clang... no
configure: GCC version: 4.8
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for backtrace in -lunwind... no
checking for gzread in -lz... yes
checking for curl_global_init in -lcurl... yes
checking for apr_initialize in -lapr-1... yes
checking for svn_stringbuf_create_ensure in -lsvn_subr-1... no
configure: error: cannot find libsvn_subr-1
-------------------------------------------------------------------
libsubversion-1 is required for mesos to build.
-------------------------------------------------------------------
- Mesos ReviewBot
On Oct. 7, 2014, 1:22 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 1:22 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac da1c82d
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review56457
-----------------------------------------------------------
Bad patch!
Reviews applied: [24535, 24536]
Failed command: git apply --index 24536.patch
Error:
error: src/java/jni/org_apache_mesos_state_LogState.cpp: does not exist in index
error: src/java/src/org/apache/mesos/state/LogState.java: does not exist in index
- Mesos ReviewBot
On Oct. 13, 2014, 10:27 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 10:27 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 256df0b
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac ee482fc
> configure.ac da1c82d
> src/Makefile.am d503c8d
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review57270
-----------------------------------------------------------
Bad patch!
Reviews applied: [24535, 24536]
Failed command: ./support/apply-review.sh -n -r 24536
Error:
--2014-10-18 16:49:58-- https://reviews.apache.org/r/24536/diff/raw/
Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 18329 (18K) [text/x-patch]
Saving to: '24536.patch'
0K .......... ....... 100% 550K=0.03s
2014-10-18 16:49:58 (550 KB/s) - '24536.patch' saved [18329/18329]
error: src/java/jni/org_apache_mesos_state_LogState.cpp: does not exist in index
error: src/java/src/org/apache/mesos/state/LogState.java: does not exist in index
Failed to apply patch
- Mesos ReviewBot
On Oct. 18, 2014, 4:23 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2014, 4:23 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 256df0b
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac ee482fc
> configure.ac bb4fee4
> docs/getting-started.md 1602914
> src/Makefile.am c44a9ad
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
-----------------------------------------------------------
(Updated Oct. 18, 2014, 4:23 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Able to build with OSX and Ubuntu 14.04.
(Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 256df0b
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac ee482fc
configure.ac bb4fee4
docs/getting-started.md 1602914
src/Makefile.am c44a9ad
Diff: https://reviews.apache.org/r/26214/diff/
Testing
-------
make
Thanks,
Timothy Chen
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review57258
-----------------------------------------------------------
Bad patch!
Reviews applied: [24535, 24536]
Failed command: ./support/apply-review.sh -n -r 24536
Error:
--2014-10-18 01:31:08-- https://reviews.apache.org/r/24536/diff/raw/
Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 15275 (15K) [text/x-patch]
Saving to: '24536.patch'
0K .......... .... 100% 457K=0.03s
2014-10-18 01:31:08 (457 KB/s) - '24536.patch' saved [15275/15275]
error: src/java/jni/org_apache_mesos_state_LogState.cpp: does not exist in index
error: src/java/src/org/apache/mesos/state/LogState.java: does not exist in index
Failed to apply patch
- Mesos ReviewBot
On Oct. 18, 2014, 12:12 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2014, 12:12 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 256df0b
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac ee482fc
> configure.ac bb4fee4
> docs/getting-started.md 1602914
> src/Makefile.am c44a9ad
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
-----------------------------------------------------------
(Updated Oct. 18, 2014, 12:12 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated getting started doc
Repository: mesos-git
Description
-------
Able to build with OSX and Ubuntu 14.04.
(Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 256df0b
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac ee482fc
configure.ac bb4fee4
docs/getting-started.md 1602914
src/Makefile.am c44a9ad
Diff: https://reviews.apache.org/r/26214/diff/
Testing
-------
make
Thanks,
Timothy Chen
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
-----------------------------------------------------------
(Updated Oct. 13, 2014, 10:27 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
rebased
Repository: mesos-git
Description
-------
Able to build with OSX and Ubuntu 14.04.
(Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 256df0b
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac ee482fc
configure.ac da1c82d
src/Makefile.am d503c8d
Diff: https://reviews.apache.org/r/26214/diff/
Testing
-------
make
Thanks,
Timothy Chen
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 1:22 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Able to build with OSX and Ubuntu 14.04.
(Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac 501de40
configure.ac da1c82d
src/Makefile.am 27c42df
Diff: https://reviews.apache.org/r/26214/diff/
Testing
-------
make
Thanks,
Timothy Chen
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
-----------------------------------------------------------
(Updated Oct. 6, 2014, 7:04 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Able to build with OSX and Ubuntu 14.04.
(Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac 501de40
configure.ac da1c82d
src/Makefile.am 27c42df
Diff: https://reviews.apache.org/r/26214/diff/
Testing
-------
make
Thanks,
Timothy Chen
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote:
> > Any reason why there's no bundled version for these, like we did for other libraries?
> >
> > I don't see this on my Mac and would like to avoid needing a special ./configure flag.
>
> Timothy Chen wrote:
> I was wondering if I should bundle it or not as well. Do we have a guideline what we usually bundle and what we usually don't?
I'm actually able to help use brew install and not use any special flags on mac. I can give out more instructions later too.
I don't think we really need to bundle this since it's available packages on linux and mac.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55251
-----------------------------------------------------------
On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote:
> > Any reason why there's no bundled version for these, like we did for other libraries?
> >
> > I don't see this on my Mac and would like to avoid needing a special ./configure flag.
I was wondering if I should bundle it or not as well. Do we have a guideline what we usually bundle and what we usually don't?
> On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote:
> > configure.ac, line 610
> > <https://reviews.apache.org/r/26214/diff/2/?file=711496#file711496line610>
> >
> > Why two folders?
It's been installed as apr-1 in some systems and apr-1.0 as other systems, I've searched online on other project's configure.ac on how they included apr and I see they basically did the same thing.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55251
-----------------------------------------------------------
On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote:
> > Any reason why there's no bundled version for these, like we did for other libraries?
> >
> > I don't see this on my Mac and would like to avoid needing a special ./configure flag.
>
> Timothy Chen wrote:
> I was wondering if I should bundle it or not as well. Do we have a guideline what we usually bundle and what we usually don't?
>
> Timothy Chen wrote:
> I'm actually able to help use brew install and not use any special flags on mac. I can give out more instructions later too.
> I don't think we really need to bundle this since it's available packages on linux and mac.
>
> Benjamin Hindman wrote:
> I'd love to avoid bundling this if possible, just like we avoid bundling SASL. One alternative would be to conditionally compile the code that uses this, but in the long run the plan is to avoid bundling all together!
> but in the long run the plan is to avoid bundling all together!
What is the long term plan? I'm thinking about things that I can't easily install, like picojson.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55251
-----------------------------------------------------------
On Oct. 6, 2014, 7:04 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 7:04 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac da1c82d
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote:
> > Any reason why there's no bundled version for these, like we did for other libraries?
> >
> > I don't see this on my Mac and would like to avoid needing a special ./configure flag.
>
> Timothy Chen wrote:
> I was wondering if I should bundle it or not as well. Do we have a guideline what we usually bundle and what we usually don't?
>
> Timothy Chen wrote:
> I'm actually able to help use brew install and not use any special flags on mac. I can give out more instructions later too.
> I don't think we really need to bundle this since it's available packages on linux and mac.
I'd love to avoid bundling this if possible, just like we avoid bundling SASL. One alternative would be to conditionally compile the code that uses this, but in the long run the plan is to avoid bundling all together!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55251
-----------------------------------------------------------
On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote:
> > configure.ac, line 610
> > <https://reviews.apache.org/r/26214/diff/2/?file=711496#file711496line610>
> >
> > Why two folders?
>
> Timothy Chen wrote:
> It's been installed as apr-1 in some systems and apr-1.0 as other systems, I've searched online on other project's configure.ac on how they included apr and I see they basically did the same thing.
Let's add that as a comment directly over where we set these includes please! ;-)
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55251
-----------------------------------------------------------
On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55251
-----------------------------------------------------------
Any reason why there's no bundled version for these, like we did for other libraries?
I don't see this on my Mac and would like to avoid needing a special ./configure flag.
configure.ac
<https://reviews.apache.org/r/26214/#comment95641>
Why two folders?
- Ben Mahler
On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/#review55268
-----------------------------------------------------------
Bad patch!
Reviews applied: [24535, 24536, 24537, 26214]
Failed command: ./configure
Error:
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
configure: Setting up build environment for x86_64 linux-gnu
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking if compiling with clang... no
configure: GCC version: 4.8
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for backtrace in -lunwind... no
checking for gzread in -lz... yes
checking for curl_global_init in -lcurl... yes
checking for apr_initialize in -lapr-1... no
configure: error: cannot find libapr-1
-------------------------------------------------------------------
libapr-1 is required for mesos to build.
-------------------------------------------------------------------
- Mesos ReviewBot
On Oct. 2, 2014, 7:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26214/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Able to build with OSX and Ubuntu 14.04.
>
> (Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
> 3rdparty/libprocess/configure.ac 501de40
> configure.ac 86d448c
> src/Makefile.am 27c42df
>
> Diff: https://reviews.apache.org/r/26214/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26214: Add apr and svn to configure.ac
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26214/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 7:06 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Able to build with OSX and Ubuntu 14.04.
(Needed to specific --with-svn with OSX since it's installed in usr/local with brew)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac 501de40
configure.ac 86d448c
src/Makefile.am 27c42df
Diff: https://reviews.apache.org/r/26214/diff/
Testing
-------
make
Thanks,
Timothy Chen