[jira] [Closed] (MSKINS-185) Don't fall back anymore if bannerLeft ist not provided

["Michael Osipov (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MSKINS-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov closed MSKINS-185.
---------------------------------
    Resolution: Fixed

Fixed with [f73171b0d0ef564a9db1e69978e78f943e845a0f|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=f73171b0d0ef564a9db1e69978e78f943e845a0f].

> Don't fall back anymore if bannerLeft ist not provided
> ------------------------------------------------------
>
>                 Key: MSKINS-185
>                 URL: https://issues.apache.org/jira/browse/MSKINS-185
>             Project: Maven Skins
>          Issue Type: Improvement
>          Components: Fluido Skin
>    Affects Versions: fluido-1.10.0
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: fluido-1.11.0
>
>
> {{bannerLeft}} is always populated if no site.xml is given:
> https://github.com/apache/maven-doxia-sitetools/blob/9a34df07c7d2e56f4f3eab3c742e532ab60d79fb/doxia-integration-tools/src/main/resources/default-site.xml#L21-L33
> If site.xml is given and not set, it will be autoset:
> https://github.com/apache/maven-doxia-sitetools/blob/9a34df07c7d2e56f4f3eab3c742e532ab60d79fb/doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java#L471-L477
> So the fallback as no effect because {{bannerLeft}} is always present. Also use {{<h1/>}} to indicate a top most header.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)