[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #150: Scala 3 support

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #150:
URL: https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1203927407


##########
.asf.yaml:
##########
@@ -35,11 +35,6 @@ github:
         # contexts are the names of checks that must pass
         contexts:
           - Code is formatted
-          - Check headers
-      required_pull_request_reviews:

Review Comment:
   We probably don't want to remove this



##########
build.sbt:
##########
@@ -11,7 +11,7 @@ import sbtdynver.GitDescribeOutput
 import spray.boilerplate.BoilerplatePlugin
 import com.lightbend.paradox.apidoc.ApidocPlugin.autoImport.apidocRootPackage
 
-sourceDistName := "incubating-pekko-http"
+sourceDistName := "incubator-pekko-http"

Review Comment:
   we can't do this revert



##########
.github/workflows/nightly.yml:
##########
@@ -18,7 +18,7 @@ jobs:
         PEKKO_VERSION: [default, main]
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v2

Review Comment:
   can we avoid this revert?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org