You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/09 02:25:55 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

Apache9 commented on a change in pull request #2037:
URL: https://github.com/apache/hbase/pull/2037#discussion_r451927555



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java
##########
@@ -128,14 +124,8 @@
 public class CanaryTool implements Tool, Canary {
   public static final String HBASE_CANARY_INFO_PORT = "hbase.canary.info.port";
 
-  public static final int DEFAULT_CANARY_INFOPORT = 16050;
-
-  public static final String HBASE_CANARY_INFO_BINDADDRESS = "hbase.canary.info.bindAddress";

Review comment:
       Why removing the static final declaration and use the string literal directly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org