You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/24 03:58:48 UTC

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #156: [WIP] Support loading Python agent through sw-python CLI

kezhenxu94 commented on pull request #156:
URL: https://github.com/apache/skywalking-python/pull/156#issuecomment-904302575


   > I'm actually thinking what if I change/ duplicate our existing plugin unit tests to use the `sw-python` command in docker-compose command, instead of calling agent in those `consumer` `provider`s, that should work.
   > 
   > Idk if we need to keep the old tests that directly call `agent.start()`, just that having two versions doing essentially the same thing will double the GHA running time, which seems awfully long.
   
   What I think is to replace all existing tests with the `sw-python` as we will recommend users to adapt the later method after it gets merged, we don't need to duplicate the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org