You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Nathan Beyer (JIRA)" <ji...@apache.org> on 2006/04/22 02:18:05 UTC

[jira] Created: (HARMONY-391) [classlib][luni] Use StringBuilder in MsgHelp.format() and test case

[classlib][luni] Use StringBuilder in MsgHelp.format() and test case
--------------------------------------------------------------------

         Key: HARMONY-391
         URL: http://issues.apache.org/jira/browse/HARMONY-391
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Nathan Beyer
    Priority: Minor


Converting the MsgHelp.format() method to use StringBuilder instead of StringBuffer, since there's no concurrency involved. Additionally, add a basic test case for the method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (HARMONY-391) [classlib][luni] Use StringBuilder in MsgHelp.format() and test case

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-391?page=comments#action_12378424 ] 

Nathan Beyer commented on HARMONY-391:
--------------------------------------

Looks good to me. Thanks for the commit.

> [classlib][luni] Use StringBuilder in MsgHelp.format() and test case
> --------------------------------------------------------------------
>
>          Key: HARMONY-391
>          URL: http://issues.apache.org/jira/browse/HARMONY-391
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: MsgHelpTest.java, MsgHelp_use_StringBuilder_patch.txt
>
> Converting the MsgHelp.format() method to use StringBuilder instead of StringBuffer, since there's no concurrency involved. Additionally, add a basic test case for the method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (HARMONY-391) [classlib][luni] Use StringBuilder in MsgHelp.format() and test case

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-391?page=all ]
     
George Harley closed HARMONY-391:
---------------------------------


Verified by Nathan.

> [classlib][luni] Use StringBuilder in MsgHelp.format() and test case
> --------------------------------------------------------------------
>
>          Key: HARMONY-391
>          URL: http://issues.apache.org/jira/browse/HARMONY-391
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: MsgHelpTest.java, MsgHelp_use_StringBuilder_patch.txt
>
> Converting the MsgHelp.format() method to use StringBuilder instead of StringBuffer, since there's no concurrency involved. Additionally, add a basic test case for the method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (HARMONY-391) [classlib][luni] Use StringBuilder in MsgHelp.format() and test case

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-391?page=all ]
     
George Harley resolved HARMONY-391:
-----------------------------------

    Resolution: Fixed

Hi Nathan, 

Patch committed in revision 405045. Please could you verify that you are happy with how it was applied.

Thank you for this enhancement. 

Best regards, 
George

> [classlib][luni] Use StringBuilder in MsgHelp.format() and test case
> --------------------------------------------------------------------
>
>          Key: HARMONY-391
>          URL: http://issues.apache.org/jira/browse/HARMONY-391
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: MsgHelpTest.java, MsgHelp_use_StringBuilder_patch.txt
>
> Converting the MsgHelp.format() method to use StringBuilder instead of StringBuffer, since there's no concurrency involved. Additionally, add a basic test case for the method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (HARMONY-391) [classlib][luni] Use StringBuilder in MsgHelp.format() and test case

Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-391?page=all ]

Nathan Beyer updated HARMONY-391:
---------------------------------

    Attachment: MsgHelp_use_StringBuilder_patch.txt
                MsgHelpTest.java

> [classlib][luni] Use StringBuilder in MsgHelp.format() and test case
> --------------------------------------------------------------------
>
>          Key: HARMONY-391
>          URL: http://issues.apache.org/jira/browse/HARMONY-391
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Priority: Minor
>  Attachments: MsgHelpTest.java, MsgHelp_use_StringBuilder_patch.txt
>
> Converting the MsgHelp.format() method to use StringBuilder instead of StringBuffer, since there's no concurrency involved. Additionally, add a basic test case for the method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (HARMONY-391) [classlib][luni] Use StringBuilder in MsgHelp.format() and test case

Posted by "George Harley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-391?page=all ]

George Harley reassigned HARMONY-391:
-------------------------------------

    Assign To: George Harley

> [classlib][luni] Use StringBuilder in MsgHelp.format() and test case
> --------------------------------------------------------------------
>
>          Key: HARMONY-391
>          URL: http://issues.apache.org/jira/browse/HARMONY-391
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Nathan Beyer
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: MsgHelpTest.java, MsgHelp_use_StringBuilder_patch.txt
>
> Converting the MsgHelp.format() method to use StringBuilder instead of StringBuffer, since there's no concurrency involved. Additionally, add a basic test case for the method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira