You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafodion.apache.org by Dave Birdsall <da...@esgyn.com> on 2015/07/13 18:35:32 UTC
Pull request mechanics question
Hi,
A stupid question about pull request mechanics. I've followed the
committers workflow on a few changes.
I take it that doing the "git push apache HEAD:master" does not close the
pull request automatically?
Is it closing the JIRA that closes the pull request? What if there was no
JIRA?
Well, I guess the more general question is: What causes the pull request to
be closed?
Thanks,
Dave
Re: Pull request mechanics question
Posted by Dave Birdsall <da...@esgyn.com>.
Hi,
I'm not sure what happened to pull requests #23 and #24 then. There is a
comment in both that hubbot has merged the changes however the pull request
has not been closed.
Dave
On Mon, Jul 13, 2015 at 10:27 AM, Steve Varnau <st...@esgyn.com>
wrote:
> Hi,
>
> I also see that GitHub can show who made the merge commit, but does not
> necessarily relate that to a GitHub user.
>
> Committers, if you add your @apache.org email address as one of your email
> addresses in your github profile, it will link those identities together.
>
> -Steve
>
> On Mon, Jul 13, 2015 at 9:52 AM, Steve Varnau <st...@esgyn.com>
> wrote:
>
> > Dave,
> >
> > Not a stupid question. But if you look at some of the resolved JIRAs
> > and/or the matching closed pull requests, you can see the comments posted
> > by the "ASF GitHub Bot". It posts a comment to JIRA that says:
> >
> > To close this pull request, make a commit to your master/trunk branch
> with
> > (at least) the following in the commit message:
> >
> > This closes #18
> >
> >
> > We have not been following that prescribed comment, but ASF GitHub Bot
> > still recognizes when the commits are merged and closes the PR
> > automatically. It does not close the JIRA.
> >
> > -Steve
> >
> > On Mon, Jul 13, 2015 at 9:35 AM, Dave Birdsall <da...@esgyn.com>
> > wrote:
> >
> >> Hi,
> >>
> >> A stupid question about pull request mechanics. I've followed the
> >> committers workflow on a few changes.
> >>
> >> I take it that doing the "git push apache HEAD:master" does not close
> the
> >> pull request automatically?
> >>
> >> Is it closing the JIRA that closes the pull request? What if there was
> no
> >> JIRA?
> >>
> >> Well, I guess the more general question is: What causes the pull request
> >> to
> >> be closed?
> >>
> >> Thanks,
> >>
> >> Dave
> >>
> >
> >
> >
> > --
> > -Steve
> >
>
>
>
> --
> -Steve
>
Re: Pull request mechanics question
Posted by Steve Varnau <st...@esgyn.com>.
Roberta,
Since you opened the pull request, you can close it.
-Steve
On Mon, Jul 13, 2015 at 10:49 AM, Roberta Marton <ro...@esgyn.com>
wrote:
> Dave committed pull request 23 which is a change for JIRA 20. I do not
> see any comments in JIRA 20 by "ASF GitHub Bot" indicating that is was
> delivered. I am the owner of the JIRA but the JIRA was unassigned when
> Dave committed the change, I received no e-mail about the event. Should I
> get something?
>
> It looks like now, I should add a comment to pull request 23 - "This closes
> #23"
> Then I can close JIRA 20.
>
> Roberta
>
> On Mon, Jul 13, 2015 at 10:27 AM, Steve Varnau <st...@esgyn.com>
> wrote:
>
> > Hi,
> >
> > I also see that GitHub can show who made the merge commit, but does not
> > necessarily relate that to a GitHub user.
> >
> > Committers, if you add your @apache.org email address as one of your
> email
> > addresses in your github profile, it will link those identities together.
> >
> > -Steve
> >
> > On Mon, Jul 13, 2015 at 9:52 AM, Steve Varnau <st...@esgyn.com>
> > wrote:
> >
> > > Dave,
> > >
> > > Not a stupid question. But if you look at some of the resolved JIRAs
> > > and/or the matching closed pull requests, you can see the comments
> posted
> > > by the "ASF GitHub Bot". It posts a comment to JIRA that says:
> > >
> > > To close this pull request, make a commit to your master/trunk branch
> > with
> > > (at least) the following in the commit message:
> > >
> > > This closes #18
> > >
> > >
> > > We have not been following that prescribed comment, but ASF GitHub Bot
> > > still recognizes when the commits are merged and closes the PR
> > > automatically. It does not close the JIRA.
> > >
> > > -Steve
> > >
> > > On Mon, Jul 13, 2015 at 9:35 AM, Dave Birdsall <
> dave.birdsall@esgyn.com>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> A stupid question about pull request mechanics. I've followed the
> > >> committers workflow on a few changes.
> > >>
> > >> I take it that doing the "git push apache HEAD:master" does not close
> > the
> > >> pull request automatically?
> > >>
> > >> Is it closing the JIRA that closes the pull request? What if there was
> > no
> > >> JIRA?
> > >>
> > >> Well, I guess the more general question is: What causes the pull
> request
> > >> to
> > >> be closed?
> > >>
> > >> Thanks,
> > >>
> > >> Dave
> > >>
> > >
> > >
> > >
> > > --
> > > -Steve
> > >
> >
> >
> >
> > --
> > -Steve
> >
>
--
-Steve
Re: Pull request mechanics question
Posted by Roberta Marton <ro...@esgyn.com>.
Dave committed pull request 23 which is a change for JIRA 20. I do not
see any comments in JIRA 20 by "ASF GitHub Bot" indicating that is was
delivered. I am the owner of the JIRA but the JIRA was unassigned when
Dave committed the change, I received no e-mail about the event. Should I
get something?
It looks like now, I should add a comment to pull request 23 - "This closes
#23"
Then I can close JIRA 20.
Roberta
On Mon, Jul 13, 2015 at 10:27 AM, Steve Varnau <st...@esgyn.com>
wrote:
> Hi,
>
> I also see that GitHub can show who made the merge commit, but does not
> necessarily relate that to a GitHub user.
>
> Committers, if you add your @apache.org email address as one of your email
> addresses in your github profile, it will link those identities together.
>
> -Steve
>
> On Mon, Jul 13, 2015 at 9:52 AM, Steve Varnau <st...@esgyn.com>
> wrote:
>
> > Dave,
> >
> > Not a stupid question. But if you look at some of the resolved JIRAs
> > and/or the matching closed pull requests, you can see the comments posted
> > by the "ASF GitHub Bot". It posts a comment to JIRA that says:
> >
> > To close this pull request, make a commit to your master/trunk branch
> with
> > (at least) the following in the commit message:
> >
> > This closes #18
> >
> >
> > We have not been following that prescribed comment, but ASF GitHub Bot
> > still recognizes when the commits are merged and closes the PR
> > automatically. It does not close the JIRA.
> >
> > -Steve
> >
> > On Mon, Jul 13, 2015 at 9:35 AM, Dave Birdsall <da...@esgyn.com>
> > wrote:
> >
> >> Hi,
> >>
> >> A stupid question about pull request mechanics. I've followed the
> >> committers workflow on a few changes.
> >>
> >> I take it that doing the "git push apache HEAD:master" does not close
> the
> >> pull request automatically?
> >>
> >> Is it closing the JIRA that closes the pull request? What if there was
> no
> >> JIRA?
> >>
> >> Well, I guess the more general question is: What causes the pull request
> >> to
> >> be closed?
> >>
> >> Thanks,
> >>
> >> Dave
> >>
> >
> >
> >
> > --
> > -Steve
> >
>
>
>
> --
> -Steve
>
Re: Pull request mechanics question
Posted by Steve Varnau <st...@esgyn.com>.
Hi,
I also see that GitHub can show who made the merge commit, but does not
necessarily relate that to a GitHub user.
Committers, if you add your @apache.org email address as one of your email
addresses in your github profile, it will link those identities together.
-Steve
On Mon, Jul 13, 2015 at 9:52 AM, Steve Varnau <st...@esgyn.com>
wrote:
> Dave,
>
> Not a stupid question. But if you look at some of the resolved JIRAs
> and/or the matching closed pull requests, you can see the comments posted
> by the "ASF GitHub Bot". It posts a comment to JIRA that says:
>
> To close this pull request, make a commit to your master/trunk branch with
> (at least) the following in the commit message:
>
> This closes #18
>
>
> We have not been following that prescribed comment, but ASF GitHub Bot
> still recognizes when the commits are merged and closes the PR
> automatically. It does not close the JIRA.
>
> -Steve
>
> On Mon, Jul 13, 2015 at 9:35 AM, Dave Birdsall <da...@esgyn.com>
> wrote:
>
>> Hi,
>>
>> A stupid question about pull request mechanics. I've followed the
>> committers workflow on a few changes.
>>
>> I take it that doing the "git push apache HEAD:master" does not close the
>> pull request automatically?
>>
>> Is it closing the JIRA that closes the pull request? What if there was no
>> JIRA?
>>
>> Well, I guess the more general question is: What causes the pull request
>> to
>> be closed?
>>
>> Thanks,
>>
>> Dave
>>
>
>
>
> --
> -Steve
>
--
-Steve
Re: Pull request mechanics question
Posted by Steve Varnau <st...@esgyn.com>.
Dave,
Not a stupid question. But if you look at some of the resolved JIRAs and/or
the matching closed pull requests, you can see the comments posted by the
"ASF GitHub Bot". It posts a comment to JIRA that says:
To close this pull request, make a commit to your master/trunk branch with
(at least) the following in the commit message:
This closes #18
We have not been following that prescribed comment, but ASF GitHub Bot
still recognizes when the commits are merged and closes the PR
automatically. It does not close the JIRA.
-Steve
On Mon, Jul 13, 2015 at 9:35 AM, Dave Birdsall <da...@esgyn.com>
wrote:
> Hi,
>
> A stupid question about pull request mechanics. I've followed the
> committers workflow on a few changes.
>
> I take it that doing the "git push apache HEAD:master" does not close the
> pull request automatically?
>
> Is it closing the JIRA that closes the pull request? What if there was no
> JIRA?
>
> Well, I guess the more general question is: What causes the pull request to
> be closed?
>
> Thanks,
>
> Dave
>
--
-Steve