You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/14 02:54:17 UTC

[GitHub] [airflow] jithin97 opened a new pull request #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter

jithin97 opened a new pull request #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter
URL: https://github.com/apache/airflow/pull/7159
 
 
   ### Description
   Current Airflow Web UI doesn't show `upstream_failed` failed filter in graph and tree view of the executed task.
   
   **Example**:
   <img width="488" alt="Screen Shot 2020-01-13 at 15 03 50" src="https://user-images.githubusercontent.com/13610191/72310195-7dc87300-36c4-11ea-9146-cce59e58c389.png">
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter
URL: https://github.com/apache/airflow/pull/7159#issuecomment-575115306
 
 
   Awesome work, congrats on your first merged pull request!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb merged pull request #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter
URL: https://github.com/apache/airflow/pull/7159
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] jithin97 commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter

Posted by GitBox <gi...@apache.org>.
jithin97 commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter
URL: https://github.com/apache/airflow/pull/7159#issuecomment-574946733
 
 
   > When making UI changes like this it's helpful to include a before-and-after. Could you please?
   > 
   > It's probably fine, but by you include a screen shot it makes it easier for the reviewer to check the colours used are sensible.
   
   @ashb Thanks!!!
   
   **Before:**
   <img width="488" alt="Screen Shot 2020-01-13 at 15 03 50" src="https://user-images.githubusercontent.com/13610191/72486901-a0d35e00-384f-11ea-8d36-8522c8719d23.png">
   
   **After**
   ![Screen Shot 2020-01-16 at 10 59 25](https://user-images.githubusercontent.com/13610191/72486885-93b66f00-384f-11ea-8429-81c8d8419169.png)
   ![Screen Shot 2020-01-16 at 11 00 42](https://user-images.githubusercontent.com/13610191/72486890-9749f600-384f-11ea-946d-879b46f40586.png)
   
   BTW this is where I took the color from. https://github.com/apache/airflow/blob/1.10.7/airflow/utils/state.py#L77

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter
URL: https://github.com/apache/airflow/pull/7159#issuecomment-574098165
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7159?src=pr&el=h1) Report
   > Merging [#7159](https://codecov.io/gh/apache/airflow/pull/7159?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a0568b9536225a89e7364278450f2677fd2851d3?src=pr&el=desc) will **increase** coverage by `0.17%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7159/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7159?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #7159      +/-   ##
   =========================================
   + Coverage   85.43%   85.6%   +0.17%     
   =========================================
     Files         710     710              
     Lines       39373   40166     +793     
   =========================================
   + Hits        33639   34385     +746     
   - Misses       5734    5781      +47
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7159?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7159/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
   | [airflow/contrib/hooks/gcp\_container\_hook.py](https://codecov.io/gh/apache/airflow/pull/7159/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb250YWluZXJfaG9vay5weQ==) | `100% <0%> (ø)` | :arrow_up: |
   | [...irflow/contrib/operators/gcp\_container\_operator.py](https://codecov.io/gh/apache/airflow/pull/7159/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29udGFpbmVyX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
   | [airflow/gcp/operators/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7159/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2JpZ3F1ZXJ5LnB5) | `92.88% <0%> (+0.79%)` | :arrow_up: |
   | [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7159/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `92.58% <0%> (+1.17%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7159?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7159?src=pr&el=footer). Last update [a0568b9...fd13d9a](https://codecov.io/gh/apache/airflow/pull/7159?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter
URL: https://github.com/apache/airflow/pull/7159#issuecomment-574743346
 
 
   When making UI changes like this it's helpful to include a before-and-after. Could you please?
   
   It's probably fine, but by you include a screen shot it makes it easier for the reviewer to check the colours used are sensible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services