You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/15 19:37:16 UTC

[GitHub] [camel-quarkus] ppalaga opened a new issue #1531: RabbitMQ native support

ppalaga opened a new issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531


   Contributions are welcome. Adding an integration test would the the first step. ActiveMQ is a good place to look how such an integration test should look like https://github.com/apache/camel-quarkus/tree/master/integration-tests/activemq


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690932752






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga closed issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga closed issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-678754136


   Great. Thanks. Now, I almost feel ashamed. I could have simply diffed the two POM files from the ActiveMQ test with mine ... :blush:  and seen it. I just ran the test again and it was successful. Thank you :smiley: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-679225048


   > here is perhaps some potential to state the relationship between `camel.component.*` props and `camel-quarkus-main` even clearer. We should perhaps also mention it somewhere in the contributor guide.
   
   Addressed in https://github.com/apache/camel-quarkus/pull/1579/commits/9752ff694fd4ad5607be25ac69c5481789930fe7


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-678757599


   @ppalaga I've created a PR. Please review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-674700515


   Oh, great. I'll check it out!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690967433


   I think you are making a valid point. Could you please file a new issue for that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690278300


   Shouldn't it be version 1.1.0? 
   https://camel.apache.org/camel-quarkus/latest/reference/extensions/rabbitmq.html
   https://github.com/apache/camel-quarkus/milestone/5?closed=1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-679225507


   Thanks again, @Jeansen !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-679225356


   Resolved via #1567


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690305548


   Well, native support is indeed since 1.1.0, but the JVM-only extension was there since 1.0.0. So the extension as a whole is since 1.0.0. Should we make this more explicit on the web page?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-678694360


   For the `camel.component.*` props (that you produce in RabbitmqTestResource) to be picked by the application, you need to add the `camel-quarkus-main` dependency to the test project. It is documented [here](https://camel.apache.org/camel-quarkus/latest/user-guide/bootstrap.html#_camel_main), but there is perhaps some potential to state the relationship between `camel.component.*` props and `camel-quarkus-main` even clearer. We should perhaps also mention it somewhere in the contributor guide.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-674441701


   @ppalaga That was a quick reply ;-) I've already checked how the project is setup with extensions for quarkus and JVM. I also thought that the ActiveMQ extension would be a candidate to start with. Currently I am all new to Quarkus and Camel. But maybe I'll be able to contribute something.
   
   So far I've already created a simple project with a camel route on my local system. Building native worked and the program spits out the same text when run in JVM (dev) mode.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690967433






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690932752






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-674535377


   Feel free to ask if you have specific questions. We also have a step by step guide for promoting extensions from JVM to native https://camel.apache.org/camel-quarkus/latest/contributor-guide/promote-jvm-to-native.html 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690932752


   Hm, I am not sure. It might be of interest. At the moment there are not that many versions but in the future it might be of interest since which version native support is available. There might be situations where users simply cannot use the latest versions but have to stick to a specific version. So the argument would be not to use the latest but at least a the version that also supports native. 
   
   Long story short: I would say yes and suggest to also ad a column for native :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-678457286


   I've forked the project and stared implementing an integration test. @ppalaga Would you assign this issue to me, then?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] Jeansen commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
Jeansen commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-678625076


   @ppalaga I've started the integration test. But for some reason I cannot get it connect to the container. Obviously I am missing something but maybe you could direct me?
   
   https://github.com/apache/camel-quarkus/compare/master...Jeansen:rabbitmq-quarkus-native?expand=1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1531: RabbitMQ native support

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1531:
URL: https://github.com/apache/camel-quarkus/issues/1531#issuecomment-690967433






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org