You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Andrea Smyth <an...@iona.com> on 2007/05/31 20:47:11 UTC
Re: svn commit: r542728 [1/2] - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/tools/
api/src/main/java/org/apache/cxf/tools/validator/ api/src/main/java/org/apache/cxf/wsdl/
rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/wsdl11/ rt/...
mmao@apache.org wrote:
>Author: mmao
>Date: Tue May 29 19:38:51 2007
>New Revision: 542728
>
>URL: http://svn.apache.org/viewvc?view=rev&rev=542728
>Log:
>CXF-658 Tool dependecies on runtime components
>* Move xsd(s) from tools/common back to runtime
>* Add plugin api to create the wsdl extensibility, to create the binding/addresses which can be added into wsdl model
>* Move service validator API, and move the XMLFormat validator to xml binding
>* Move testing resources into resources dir
>* Remove system.out in tests
>* Move some of tools tests which depend on rt to wsdlto/tests, otherwise will have a cycle dependencies
>
>
Hi James,
This dependency should be removed also, e.g. by using test transport and
binding extensions instead of the real ones defined in the jms and
xml-binding module.
But a new dependency of cxf-tools-misctools on (WsdlDefinitionBuilder
in) cxf-rt-core was introduced.
I believe this goes unnoticed when building from the top by shceduling
the rt-core accordingly, but it does not work when when you do a clean
from the top, then an install in tools, then install in rt ()which is
what I do, and what should be supported).
Can you revisit these dependecies?
Andrea.
Re: svn commit: r542728 [1/2] - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/tools/
api/src/main/java/org/apache/cxf/tools/validator/ api/src/main/java/org/apache/cxf/wsdl/
rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/wsdl11/ rt/...
Posted by Andrea Smyth <an...@iona.com>.
James Mao wrote:
> Hi Andrea,
>
> This is not a new dependency, it's been there for a long time since we
> refactoring tools.
> And i just tried what you tried, top '*mvn clean*' and then tools
> '*mvn install*', and i got a successful build.
> and then go into the rt do a '*mvn install*' i got another successful
> build.
> Tested the above on RHEL 3.0 and Windows Vista.
>
> Can you try again?
> If it still not work for you, can you please send the error message.
Hi James,
IIRC, it failed to build in tools because the newly introduced
constructor to WsdlDefinitionBuilder (the one with a boolean argument)
was not known.
As this was my first build including that change, this is not suprising.
Now it works as the cxf-rt-core jar in my local repository has that
change. I am sure I can reproduce the problem after I wipe out my local
repository and build offline. Don't have time for that now though ..
Andrea.
Re: svn commit: r542728 [1/2] - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/tools/
api/src/main/java/org/apache/cxf/tools/validator/ api/src/main/java/org/apache/cxf/wsdl/
rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/wsdl11/ rt/...
Posted by James Mao <ja...@iona.com>.
Hi Andrea,
This is not a new dependency, it's been there for a long time since we
refactoring tools.
And i just tried what you tried, top '*mvn clean*' and then tools '*mvn
install*', and i got a successful build.
and then go into the rt do a '*mvn install*' i got another successful build.
Tested the above on RHEL 3.0 and Windows Vista.
Can you try again?
If it still not work for you, can you please send the error message.
I know the dependency is not that clear, the thing that i would do is
move all the binding stuff (mostly the soap binding) to the runtime,
and also move/combine some constants classes into api, so there is no rt
module need to depend on tools/common.
But the build should not fail at this point.
Regards,
James
>
> No, source in misc tools depends on the core, to be precise:
> org.apache.cxf.tools.misc.processor.AbstractWSDLToProcessor in
> cxf-tools-misctools imports
> org.apache.cxf.wsdl11.WSDLDefinitionBuilder from rt-core.
> AND there is the unnecessary dependency of a test (can't remember
> which one now) on cxf-rt-transports-jms and cxf-rt-binding-xml.
> This breaks building successively in tools, then in rt. That must work
> IMO.
>
> Andrea.
>
>> What about move all of those tests which depend on rt stuff to
>> wsdlto/tests? since wsdlto/tests is kind of system tests for tools
>> and it already depend on rt stuff.
>> And then remove the dependencies in the pom of misc tools.
>>
>> Will that work for you?
>>
>>
>>> mmao@apache.org wrote:
>>>
>>>> Author: mmao
>>>> Date: Tue May 29 19:38:51 2007
>>>> New Revision: 542728
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=542728
>>>> Log:
>>>> CXF-658 Tool dependecies on runtime components
>>>> * Move xsd(s) from tools/common back to runtime
>>>> * Add plugin api to create the wsdl extensibility, to create the
>>>> binding/addresses which can be added into wsdl model
>>>> * Move service validator API, and move the XMLFormat validator to
>>>> xml binding
>>>> * Move testing resources into resources dir
>>>> * Remove system.out in tests
>>>> * Move some of tools tests which depend on rt to wsdlto/tests,
>>>> otherwise will have a cycle dependencies
>>>>
>>>>
>>> Hi James,
>>>
>>> This dependency should be removed also, e.g. by using test transport
>>> and binding extensions instead of the real ones defined in the jms
>>> and xml-binding module.
>>>
>>> But a new dependency of cxf-tools-misctools on
>>> (WsdlDefinitionBuilder in) cxf-rt-core was introduced.
>>> I believe this goes unnoticed when building from the top by
>>> shceduling the rt-core accordingly, but it does not work when when
>>> you do a clean from the top, then an install in tools, then install
>>> in rt ()which is what I do, and what should be supported).
>>> Can you revisit these dependecies?
>>>
>>> Andrea.
>>>
>>>
>>>
>>
>
>
Re: svn commit: r542728 [1/2] - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/tools/
api/src/main/java/org/apache/cxf/tools/validator/ api/src/main/java/org/apache/cxf/wsdl/
rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/wsdl11/ rt/...
Posted by Andrea Smyth <an...@iona.com>.
James Mao wrote:
> Hi Andrea,
>
> The issue you mentioned is just the misc tools tests right?
Hi James,
No, source in misc tools depends on the core, to be precise:
org.apache.cxf.tools.misc.processor.AbstractWSDLToProcessor in
cxf-tools-misctools imports org.apache.cxf.wsdl11.WSDLDefinitionBuilder
from rt-core.
AND there is the unnecessary dependency of a test (can't remember which
one now) on cxf-rt-transports-jms and cxf-rt-binding-xml.
This breaks building successively in tools, then in rt. That must work IMO.
Andrea.
> What about move all of those tests which depend on rt stuff to
> wsdlto/tests? since wsdlto/tests is kind of system tests for tools and
> it already depend on rt stuff.
> And then remove the dependencies in the pom of misc tools.
>
> Will that work for you?
>
>
>> mmao@apache.org wrote:
>>
>>> Author: mmao
>>> Date: Tue May 29 19:38:51 2007
>>> New Revision: 542728
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=542728
>>> Log:
>>> CXF-658 Tool dependecies on runtime components
>>> * Move xsd(s) from tools/common back to runtime
>>> * Add plugin api to create the wsdl extensibility, to create the
>>> binding/addresses which can be added into wsdl model
>>> * Move service validator API, and move the XMLFormat validator to
>>> xml binding
>>> * Move testing resources into resources dir
>>> * Remove system.out in tests
>>> * Move some of tools tests which depend on rt to wsdlto/tests,
>>> otherwise will have a cycle dependencies
>>>
>>>
>> Hi James,
>>
>> This dependency should be removed also, e.g. by using test transport
>> and binding extensions instead of the real ones defined in the jms
>> and xml-binding module.
>>
>> But a new dependency of cxf-tools-misctools on (WsdlDefinitionBuilder
>> in) cxf-rt-core was introduced.
>> I believe this goes unnoticed when building from the top by
>> shceduling the rt-core accordingly, but it does not work when when
>> you do a clean from the top, then an install in tools, then install
>> in rt ()which is what I do, and what should be supported).
>> Can you revisit these dependecies?
>>
>> Andrea.
>>
>>
>>
>
Re: svn commit: r542728 [1/2] - in /incubator/cxf/trunk: api/src/main/java/org/apache/cxf/tools/
api/src/main/java/org/apache/cxf/tools/validator/ api/src/main/java/org/apache/cxf/wsdl/
rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/wsdl11/ rt/...
Posted by James Mao <ja...@iona.com>.
Hi Andrea,
The issue you mentioned is just the misc tools tests right?
What about move all of those tests which depend on rt stuff to
wsdlto/tests? since wsdlto/tests is kind of system tests for tools and
it already depend on rt stuff.
And then remove the dependencies in the pom of misc tools.
Will that work for you?
> mmao@apache.org wrote:
>
>> Author: mmao
>> Date: Tue May 29 19:38:51 2007
>> New Revision: 542728
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=542728
>> Log:
>> CXF-658 Tool dependecies on runtime components
>> * Move xsd(s) from tools/common back to runtime
>> * Add plugin api to create the wsdl extensibility, to create the
>> binding/addresses which can be added into wsdl model
>> * Move service validator API, and move the XMLFormat validator to xml
>> binding
>> * Move testing resources into resources dir
>> * Remove system.out in tests
>> * Move some of tools tests which depend on rt to wsdlto/tests,
>> otherwise will have a cycle dependencies
>>
>>
> Hi James,
>
> This dependency should be removed also, e.g. by using test transport
> and binding extensions instead of the real ones defined in the jms and
> xml-binding module.
>
> But a new dependency of cxf-tools-misctools on (WsdlDefinitionBuilder
> in) cxf-rt-core was introduced.
> I believe this goes unnoticed when building from the top by shceduling
> the rt-core accordingly, but it does not work when when you do a clean
> from the top, then an install in tools, then install in rt ()which is
> what I do, and what should be supported).
> Can you revisit these dependecies?
>
> Andrea.
>
>
>