You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2010/05/19 02:57:06 UTC

[jira] Created: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Artifact id for Maven deployment should be set to hadoop-core-system-test
-------------------------------------------------------------------------

                 Key: HADOOP-6771
                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
             Project: Hadoop Common
          Issue Type: Sub-task
            Reporter: Konstantin Boudnik
            Assignee: Konstantin Boudnik




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Status: Patch Available  (was: Open)

Patch has been regenerated thus the verification.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870931#action_12870931 ] 

Hudson commented on HADOOP-6771:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #265 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/265/])
    HADOOP-6771. Herriot's artifact id for Maven deployment should be set to
hadoop-core-instrumented. Contributed by Konstantin Boudnik.


> Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870799#action_12870799 ] 

Giridharan Kesavan commented on HADOOP-6771:
--------------------------------------------

+1 looks good

> Artifact id for Maven deployment should be set to hadoop-core-instrumented
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870801#action_12870801 ] 

Konstantin Boudnik commented on HADOOP-6771:
--------------------------------------------

I'll gonna commit this in the next a couple of hours unless there are objections. 

> Artifact id for Maven deployment should be set to hadoop-core-instrumented
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Status: Patch Available  (was: Open)

Changed again. Re-verification.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869865#action_12869865 ] 

Hadoop QA commented on HADOOP-6771:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12445131/HADOOP-6771.patch
  against trunk revision 946815.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/536/console

This message is automatically generated.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Component/s: build

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Status: Open  (was: Patch Available)

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Attachment: HADOOP-6771.patch

Patch changes artifact id to {{hadoop-core-system-test}} and adds {{-mvn-system-deploy}} target to perform artifacts deployment for test framework's jars. I have tested it locally and seems to do the right thing however I can't do actual deployment for the lack of credentials. Please review.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870790#action_12870790 ] 

Giridharan Kesavan commented on HADOOP-6771:
--------------------------------------------

patch works fine in publishing artifacts to the mvn snapshot repo.


minor stuff:
Please use ant clean target to remove the generated ivy/hadoop-core-instrumented.xml file

patch leaves 3 empty files 

ivy/hadoop-core-system.xml
ivy/hadoop-core-system-template.xml
ivy/hadoop-core-system.pom


> Artifact id for Maven deployment should be set to hadoop-core-instrumented
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869237#action_12869237 ] 

Hadoop QA commented on HADOOP-6771:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444960/HADOOP-6771.patch
  against trunk revision 945953.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/531/console

This message is automatically generated.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Attachment: HADOOP-6771.patch

In the conversation with Chris we have agreed that 'instrumented' suffix is more proper way to distinguish Herriot artifacts.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871320#action_12871320 ] 

Hudson commented on HADOOP-6771:
--------------------------------

Integrated in Hadoop-Common-trunk #346 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/346/])
    

> Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Attachment: HADOOP-6771.patch

One-liner modification according to Giri's comment: cleaning the generated file during {{clean}} invocation.

> Artifact id for Maven deployment should be set to hadoop-core-instrumented
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Tags: herriot

> Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Summary: Artifact id for Maven deployment should be set to hadoop-core-instrumented  (was: Artifact id for Maven deployment should be set to hadoop-core-system-test)

> Artifact id for Maven deployment should be set to hadoop-core-instrumented
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

               Status: Patch Available  (was: Open)
    Affects Version/s: 0.21.0
        Fix Version/s: 0.21.0

Ready for verification.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868991#action_12868991 ] 

Hadoop QA commented on HADOOP-6771:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444871/HADOOP-6771.patch
  against trunk revision 945953.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/530/console

This message is automatically generated.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Status: Open  (was: Patch Available)

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Summary: Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented  (was: Artifact id for Maven deployment should be set to hadoop-core-instrumented)

> Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

I have committed it to the trunk and 0.21 branch.

> Herriot's artifact id for Maven deployment should be set to hadoop-core-instrumented
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Boudnik updated HADOOP-6771:
---------------------------------------

    Attachment: HADOOP-6771.patch

Adressing Giri's comment I have removed mistakenly added {{hadoop-core-system-test.xml}} file and modified {{set-version}} target to generate it when needed.

The other file (and a .pom file {{hadoop-core.pom}}) were added earlier. I believe those have to go because they seem to be redundant.

> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch, HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6771) Artifact id for Maven deployment should be set to hadoop-core-system-test

Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869004#action_12869004 ] 

Giridharan Kesavan commented on HADOOP-6771:
--------------------------------------------

set-version ant target is used to set the version string and create a pom file using the template file.
In this patch I see both the template and the created file.. Any reason?

Here I see:
hadoop-core-test-template.xml
hadoop-core-test.xml
hadoop-core-system-test-template.xml
hadoop-core-system-test.xml

clean target is supposed to clean the created pom files inside the ivy folder.


> Artifact id for Maven deployment should be set to hadoop-core-system-test
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-6771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-6771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.