You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/05/02 16:57:30 UTC
[Impala-ASF-CR] IMPALA-11276: Fix TestIcebergTable.test partitioned insert became flaky
lipenglin@sensorsdata.cn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18465
Change subject: IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
......................................................................
IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
TestIcebergTable.Test_partitioned_insert test is not stable because
SHOW FILES on Iceberg table will sort the list of FILES. So restore the
original VERIFY_IS_SUBSET for some flaky cases.
Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/18465/1
--
To view, visit http://gerrit.cloudera.org:8080/18465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
Gerrit-Change-Number: 18465
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
[Impala-ASF-CR] IMPALA-11276: Fix TestIcebergTable.test partitioned insert became flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18465 )
Change subject: IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
Gerrit-Change-Number: 18465
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tomas Gavenciak <to...@nic.cz>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 May 2022 12:13:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11276: Fix TestIcebergTable.test partitioned insert became flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18465 )
Change subject: IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10523/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
Gerrit-Change-Number: 18465
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tomas Gavenciak <to...@nic.cz>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 May 2022 17:17:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11276: Fix TestIcebergTable.test partitioned insert became flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18465 )
Change subject: IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
......................................................................
IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
TestIcebergTable.Test_partitioned_insert test is not stable because
SHOW FILES on Iceberg table will sort the list of FILES. So restore the
original VERIFY_IS_SUBSET for some flaky cases.
Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
Reviewed-on: http://gerrit.cloudera.org:8080/18465
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
Gerrit-Change-Number: 18465
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tomas Gavenciak <to...@nic.cz>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11276: Fix TestIcebergTable.test partitioned insert became flaky
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18465 )
Change subject: IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
Gerrit-Change-Number: 18465
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tomas Gavenciak <to...@nic.cz>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 May 2022 07:46:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11276: Fix TestIcebergTable.test partitioned insert became flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18465 )
Change subject: IMPALA-11276: Fix TestIcebergTable.test_partitioned_insert became flaky
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8074/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic38b399ab51903edb59b3f2d1066cd5f5cbff4d4
Gerrit-Change-Number: 18465
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tomas Gavenciak <to...@nic.cz>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 May 2022 07:46:53 +0000
Gerrit-HasComments: No