[GitHub] [echarts] DanielBogenrieder commented on a diff in pull request #17579: Feat/box plot labels

[GitBox <gi...@apache.org>]

DanielBogenrieder commented on code in PR #17579:
URL: https://github.com/apache/echarts/pull/17579#discussion_r1007760902


##########
src/chart/boxplot/BoxplotView.ts:
##########
@@ -180,17 +183,76 @@ function updateNormalBoxData(
 
     el.useStyle(data.getItemVisual(dataIndex, 'style'));
     el.style.strokeNoScale = true;
-
     el.z2 = 100;
 
     const itemModel = data.getItemModel<BoxplotDataItemOption>(dataIndex);
     const emphasisModel = itemModel.getModel('emphasis');
 
+    if (seriesModel.option.label.show) {
+        const formattedLabels =
+            ((seriesModel as BoxplotSeriesModel).getRawValue(dataIndex) as number[])
+            .splice(1).map((value: number) => seriesModel.option.label.formatter(value).toString());

Review Comment:
   @Ovilia any news on this? Is the proposed solution good enough?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org