You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ma...@apache.org on 2016/01/05 19:50:16 UTC
reef git commit: [REEF-1119] Apply strict checkstyle rules and make
shade-jar file for Tang Tint
Repository: reef
Updated Branches:
refs/heads/master 91bec702e -> 030772b00
[REEF-1119] Apply strict checkstyle rules and make shade-jar file for Tang Tint
This change:
* Makes `Tint` a single shaded jar file.
* Applies strict Checkstyle rules for Tang Tint.
* Fixes a typo in the name of Tint pom.xml.
JIRA:
[REEF-1119](https://issues.apache.org/jira/browse/REEF-1119)
Pull request:
This closes #753
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/030772b0
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/030772b0
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/030772b0
Branch: refs/heads/master
Commit: 030772b00f47e4b42c32d15436750a0712b21836
Parents: 91bec70
Author: Dongjoon Hyun <do...@apache.org>
Authored: Wed Dec 30 01:12:50 2015 -0800
Committer: Mariia Mykhailova <ma...@apache.org>
Committed: Tue Jan 5 10:48:20 2016 -0800
----------------------------------------------------------------------
lang/java/reef-tang/tang-tint/pom.xml | 45 +++++++++++++++++++-
.../java/org/apache/reef/tang/util/Tint.java | 6 ++-
2 files changed, 48 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/030772b0/lang/java/reef-tang/tang-tint/pom.xml
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang-tint/pom.xml b/lang/java/reef-tang/tang-tint/pom.xml
index bc90286..d256aac 100644
--- a/lang/java/reef-tang/tang-tint/pom.xml
+++ b/lang/java/reef-tang/tang-tint/pom.xml
@@ -39,5 +39,48 @@ under the License.
</dependencies>
<artifactId>tang-tint</artifactId>
- <name>REFF Tang Tint</name>
+ <name>REEF Tang Tint</name>
+
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <configuration>
+ <configLocation>lang/java/reef-common/src/main/resources/checkstyle-strict.xml</configLocation>
+ </configuration>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <outputFile>
+ ${project.build.directory}/${project.artifactId}-${project.version}-shaded.jar
+ </outputFile>
+ <transformers>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ <manifestEntries>
+ <Main-Class>
+ org.apache.reef.tang.util.Tint
+ </Main-Class>
+ </manifestEntries>
+ </transformer>
+ </transformers>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
</project>
http://git-wip-us.apache.org/repos/asf/reef/blob/030772b0/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java b/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java
index 0108901..6eebe89 100644
--- a/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java
+++ b/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java
@@ -47,6 +47,9 @@ import java.util.Map.Entry;
import java.util.Set;
import java.util.TreeSet;
+/**
+ * Tang Static Analytics Tool.
+ */
public class Tint {
private static final String SETTERS = "setters";
private static final String USES = "uses";
@@ -390,7 +393,6 @@ public class Tint {
try {
clz = t.ch.classForName(c.getFullName());
} catch (final ClassNotFoundException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
final String typ = clz.isInterface() ? "interface" : "class";
@@ -708,7 +710,7 @@ public class Tint {
instance = "";
}
sb.append(cell(instance, "simpleName"));
- sb.append(cell("", "fullName")); // TODO: Documentation string?
+ sb.append(cell("", "fullName")); // TODO[REEF-1118]: Support documentation string
final StringBuffer uses = new StringBuffer();
for (final String u : getUsesOf(n)) {
uses.append("<a href='#" + u + "'>" + stripPrefix(u, pack) + "</a> ");