[GitHub] [nifi] thenatog commented on a change in pull request #4599: NIFI-7913 Set Enabled TLS Protocols on ListenSMTP

[GitBox <gi...@apache.org>]

thenatog commented on a change in pull request #4599:
URL: https://github.com/apache/nifi/pull/4599#discussion_r539705336



##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-ssl-context-service-api/src/main/java/org/apache/nifi/ssl/SSLContextService.java
##########
@@ -109,10 +109,10 @@
          * Prepopulate protocols with generic instance types commonly used
          * see: http://docs.oracle.com/javase/7/docs/technotes/guides/security/StandardNames.html#SSLContext
          */
-        supportedProtocols.add("TLS");
+        supportedProtocols.add(TlsConfiguration.SSL_PROTOCOL);
 
         // This is still available for outgoing connections to legacy services, but can be disabled with jdk.tls.disabledAlgorithms

Review comment:
       Tiny issue here is that the comment refers to SSL still being available for outgoing connections but this switched the order so now it's implying TLS is still available for outgoing connections to legacy services. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org